Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept gdpr-skip-tables argument #12

Open
fjgarlin opened this issue Jun 20, 2018 · 3 comments · May be fixed by #16
Open

Accept gdpr-skip-tables argument #12

fjgarlin opened this issue Jun 20, 2018 · 3 comments · May be fixed by #16

Comments

@fjgarlin
Copy link

When dumping a database we might not want to copy across or sanitize all tables (ie: cache tables). I suggest accepting this parametre (and/or in the configuration files) to be able to just create those tables but don't transfer any data.

Suggested:
"gdpr-skip-tables":["tableName1","tableName2","tableName3"]

@bomoko
Copy link
Contributor

bomoko commented Jun 22, 2018

@fjgarlin - I think we're going to need a different name for this, to me skipping tables means actually skipping the table entirely. It seems that mysqldump-php actually supports us passing through a list of tables for which skip table table -- namely the "no-data" parameter.
Here it's slightly more flexible than mysqldump itself, since mysqldump's "no-data" option seems to be an all-or-nothing affair.
So it makes sense for us to call it something else - but maybe specifying that it's skipping the data rather than the tables themselves.
Something like "gdpr-skip-table-data".
What I'll do, though, is write up a PR that uses your suggestion for now, and we can chat about it here.

@fjgarlin
Copy link
Author

Hey @bomoko, happy to change it to whatever makes sense. Do the implementation that you believe is right and I'll adapt the patch as required. Thanks!

@anthosz
Copy link

anthosz commented Nov 16, 2018

Hello,

Maybe can be useful to support also pattern in skip tables like "no-data":["cache_%","apachesolr_%"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants