Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where and how to change for setting torch.load with weights_only=False #30

Closed
revilodarnoc opened this issue Sep 23, 2024 · 1 comment · Fixed by #37
Closed

Where and how to change for setting torch.load with weights_only=False #30

revilodarnoc opened this issue Sep 23, 2024 · 1 comment · Fixed by #37

Comments

@revilodarnoc
Copy link

Running batdetect2 detect on Ubuntu return below warning message.
There is a recommendation for future torch.load but where and how to change the setting in the current release 1.08?

{install-conda}/batdetect2/lib/python3.10/site-packages/batdetect2/utils/detector_utils.py:103: FutureWarning: You are You are using torch.load with weights_only=False (the current default value), which uses the default pickle module implicitly. It is possible to construct malicious pickle data which will execute arbitrary code during unpickling(the current default value), which uses the default pickle module implicitly. It is possible to construct malicious pickle data which will execute arbitrary code during unpickling (See https://github.com/pytorch/pytorch/blob/main/SECURITY.md#untrusted-models for more details). In a future release, the default value for weights_only will be flipped to True. This limits the functions that could be executed during unpickling. Arbitrary objects will no longer be allowed to be loaded via this mode unless they are explicitly allowlisted by the user via torch.serialization.add_safe_globals. We recommend you start setting weights_only=True for any use case where you don't have full control of the loaded file. Please open an issue on GitHub for any issues related to this experimental feature.
net_params = torch.load(model_path, map_location=device)

mbsantiago added a commit that referenced this issue Nov 11, 2024
…ing-weights-only

fix: Address PyTorch Model Loading Deprecation Warning (GH-30)
@mbsantiago
Copy link
Collaborator

Thanks @revilodarnoc!

I've set weights_only to True explicitely. This does not affect model loading in our case (as verified by some tests I added just to make sure), so best to keep in line with the security advices from the torch team. Thanks again for raising this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants