Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add try/finally to ConcurrentBertClient avoid not release BertClient … #373

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add try/finally to ConcurrentBertClient avoid not release BertClient … #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions bert_base/client/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,9 +427,11 @@ def _concurrent(func):
def arg_wrapper(self, *args, **kwargs):
try:
bc = self.available_bc.pop()
f = getattr(bc, func.__name__)
r = f if isinstance(f, dict) else f(*args, **kwargs)
self.available_bc.append(bc)
try:
f = getattr(bc, func.__name__)
r = f if isinstance(f, dict) else f(*args, **kwargs)
finally:
self.available_bc.append(bc)
return r
except IndexError:
raise RuntimeError('Too many concurrent connections!'
Expand Down