Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores size attributes / doesn't support 2x Retina images #4

Open
peterflynn opened this issue Feb 20, 2019 · 0 comments
Open

Ignores size attributes / doesn't support 2x Retina images #4

peterflynn opened this issue Feb 20, 2019 · 0 comments

Comments

@peterflynn
Copy link

I'm trying to include diagrams in my documentation that look crisp on high-DPI screens. This requires setting their display size to 1/2 their actual pixel dimensions -- otherwise, the images will look huge and still be fuzzy on 2x screens.

The Fancybox plugin is posing several problems for this though:

  • Ideally it would have some nice behavior to set up the right max size for @2x images automatically, but it does not.
  • I can't manually set the right size using an <img> tag with width/height attributes or a style attribute, since this plugin replaces the entire tag with a template that blows away all attributes on the tag (see https://github.com/ly-tools/gitbook-plugin-fancybox/blob/master/index.js#L8-L10).
  • I can't find any way to make the plugin ignore certain <img> tags either.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant