-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent code style across QTermWidget #472
Comments
I'll ship a PR with the .clang-format file following Qt for the general with the addition rules you mention (brackets and spaces). We can modify the file later in the PR or other PRs. At least it's a start! |
francescmm
added a commit
to francescmm/qtermwidget
that referenced
this issue
Apr 10, 2022
francescmm
added a commit
to francescmm/qtermwidget
that referenced
this issue
Apr 10, 2022
francescmm
added a commit
to francescmm/qtermwidget
that referenced
this issue
Apr 10, 2022
francescmm
added a commit
to francescmm/qtermwidget
that referenced
this issue
Apr 10, 2022
francescmm
added a commit
to francescmm/qtermwidget
that referenced
this issue
Apr 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
I'd like the code to look consistent (same use of brackets, tabs, spaces, naming, etc.) across the different classes of QTermWidget.
Current Behavior
Every file has it's own style.
Possible Solution
Agre on a basic code style (maybe following Qt own rules) and enforce it with .clang-format file in the repo.
Steps to Reproduce (for bugs)
Context
I'm trying to read the code and go through it making modifications and improvements, but the differences between classes in the style makes it more difficult.
System Information
The text was updated successfully, but these errors were encountered: