Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDE/Konsole copyright notices #251

Open
apjanke opened this issue Mar 5, 2019 · 4 comments
Open

KDE/Konsole copyright notices #251

apjanke opened this issue Mar 5, 2019 · 4 comments

Comments

@apjanke
Copy link
Contributor

apjanke commented Mar 5, 2019

A lot of the source files in QTermWidget say they are part of Konsole or KDE.

[~/local/repos/qtermwidget]
$ grep -r "This source file is part of" *  
lib/ColorScheme.cpp:    This source file is part of Konsole, a terminal emulator.
lib/KeyboardTranslator.cpp:    This source file is part of Konsole, a terminal emulator.
lib/ColorScheme.h:    This source file is part of Konsole, a terminal emulator.
lib/KeyboardTranslator.h:    This source file is part of Konsole, a terminal emulator.
[~/local/repos/qtermwidget]
$ grep -r "This file is part of" * | head -10
lib/kptydevice.cpp:   This file is part of the KDE libraries
lib/Pty.h:    This file is part of Konsole, KDE's terminal emulator.
lib/BlockArray.cpp:    This file is part of Konsole, an X terminal.
lib/kprocess.cpp:    This file is part of the KDE libraries
lib/kprocess.h:    This file is part of the KDE libraries
[...]

That's not really accurate here, is it, since you've copied all these files into the QTermWidget project? And it will become less accurate as changes are made to those files.

What do you think of removing all the "This file is part of ..." lines, just leaving the copyright and license notices?

@yan12125
Copy link
Member

yan12125 commented Mar 5, 2019

How do you think @agaida?

@agaida
Copy link
Member

agaida commented Mar 5, 2019

I'm biased - the files was forked long time ago and might differ from the current development - so i guess a short message "was forked from KDE $version $date would make sense" - and ofcourse the original copyright should remain intact.

@agaida
Copy link
Member

agaida commented Mar 5, 2019

Second thought - in a perfect world i would like to use the libs directly if possible and wrap around it in our own programming.

@yan12125
Copy link
Member

Hmm that reminds me of another form of copyright notice:

20XX-20YY Foo devs
20YY-20ZZ Bar devs

@agaida's suggestion is also good.

And in a perfect word konsole can be built with necessary KDE libraries only (e.g., KPty), and there will be no qterminal :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants