Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiply by distributed_factor/8. #7

Open
wavy-jung opened this issue Apr 26, 2022 · 2 comments
Open

Multiply by distributed_factor/8. #7

wavy-jung opened this issue Apr 26, 2022 · 2 comments

Comments

@wavy-jung
Copy link

Thanks for posting a really nice repo!
While I was studying the code, I found that in 'train_dense_encoder.py' line 669 and 691 the following:
'''
surrogate = surrogate * (trainer.distributed_factor / 8.)
'''
which I actually don't fully understand the reason of the multiplication part.
Can you explain any reason? Thank you 👍

@luyug
Copy link
Owner

luyug commented Apr 26, 2022

Take a look at #4 to see if it help answer the question.

@wavy-jung
Copy link
Author

It helps! Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants