Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isUserBootloader() fails to check conditions correctly #1102

Open
diablodale opened this issue Aug 19, 2024 · 0 comments
Open

isUserBootloader() fails to check conditions correctly #1102

diablodale opened this issue Aug 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@diablodale
Copy link
Contributor

depthai-core v2.27.0 isUserBootloader() fails to check conditions correctly.

I think the code needs to check what is flashed...not what is currently running since it could be running from an esoteric/embedded blob. Should also check that it is a NETWORK sensor not usb, so calling isUserBootloaderSupported() fits well.

bool DeviceBootloader::isUserBootloader() {
// Check if bootloader version is adequate
if(getVersion().getSemver() < Version(Request::IsUserBootloader::VERSION)) {
return false;
}

I think that block should instead be

bool DeviceBootloader::isUserBootloader() const {
    // Check if bootloader version is adequate
    if(!isUserBootloaderSupported()) {
        return false;
    }
@diablodale diablodale added the bug Something isn't working label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant