Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group and choice options #71

Open
HassanAkbar opened this issue Sep 10, 2024 · 2 comments
Open

Add group and choice options #71

HassanAkbar opened this issue Sep 10, 2024 · 2 comments
Assignees

Comments

@HassanAkbar
Copy link
Member

XML type conditions

  • Choice: one of these
  • Group: all of these

Originally posted by @ronaldtse in #9 (comment)

@HassanAkbar HassanAkbar self-assigned this Sep 10, 2024
@HassanAkbar
Copy link
Member Author

@ronaldtse I have a few questions regarding what to validate in the above options

For choice option

  • Should we raise an error if none of the option is provided from the choice group?
  • Should we raise an error if more then one option is provided from the choice group?

For group option

  • Should we raise an error if not all the options are selected from the group?

@ronaldtse
Copy link
Contributor

For choice option

  • Should we raise an error if none of the option is provided from the choice group?

Yes, instead of raising it, add this requirement to the validate process.

  • Should we raise an error if more then one option is provided from the choice group?

Yes, instead of raising it, add this requirement to the validate process.

For group option

  • Should we raise an error if not all the options are selected from the group?

Yes, instead of raising it, add this requirement to the validate process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants