You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed in the MappingRule class there are serialize and deserialize methods that used the custom_methods. But now the custom method values are handled inside XmlAdapter classes, which is very strange.
Let's consolidate value processing (custom_method, default, value type casting) in a single location.
e.g. the Attribute class.
This is purely an internal refactor and will not require spec changes (new specs required for that new location) or behavioral changes of users.
I noticed in the
MappingRule
class there areserialize
anddeserialize
methods that used thecustom_methods
. But now the custom method values are handled inside XmlAdapter classes, which is very strange.Let's consolidate value processing (
custom_method
,default
, value type casting) in a single location.e.g. the
Attribute
class.This is purely an internal refactor and will not require spec changes (new specs required for that new location) or behavioral changes of users.
Originally posted by @ronaldtse in #45 (comment)
The text was updated successfully, but these errors were encountered: