Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate attribute value loading functionality in the Attribute class (custom methods, defaults, casting) #46

Open
ronaldtse opened this issue Aug 18, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ronaldtse
Copy link
Contributor

ronaldtse commented Aug 18, 2024

I noticed in the MappingRule class there are serialize and deserialize methods that used the custom_methods. But now the custom method values are handled inside XmlAdapter classes, which is very strange.

Let's consolidate value processing (custom_method, default, value type casting) in a single location.

e.g. the Attribute class.

This is purely an internal refactor and will not require spec changes (new specs required for that new location) or behavioral changes of users.

Originally posted by @ronaldtse in #45 (comment)

@ronaldtse ronaldtse added the enhancement New feature or request label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants