Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide proper documentation on API #94

Open
ronaldtse opened this issue Jul 17, 2021 · 4 comments
Open

Provide proper documentation on API #94

ronaldtse opened this issue Jul 17, 2021 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@ronaldtse
Copy link
Contributor

ronaldtse commented Jul 17, 2021

From @opoudjis :

There is nothing in https://github.com/lutaml/expressir that tells me how to generate a complete, unformatted schema listing from a schema.

https://github.com/metanorma/annotated-express/issues/18

Please help with this, thanks @zakjan

@ronaldtse ronaldtse added the documentation Improvements or additions to documentation label Jul 17, 2021
@zakjan
Copy link
Contributor

zakjan commented Jul 19, 2021

Hi @opoudjis @ronaldtse Model documentation is available at https://rubydoc.info/github/lutaml/expressir/master/Expressir/Model - let me know if there is anything to improve. I'm not sure what does "complete, unformatted schema listing from a schema" mean.

@zakjan
Copy link
Contributor

zakjan commented Jul 19, 2021

If you are looking for a method to generate source code, this method accepts any model instance https://rubydoc.info/github/lutaml/expressir/master/Expressir/Express/Formatter#format-class_method

@ronaldtse
Copy link
Contributor Author

ronaldtse commented Jul 21, 2021

@zakjan can we have:

Screenshot 2021-07-21 at 4 52 27 PM

Could we supplement this with the actual text from the document?

@zakjan
Copy link
Contributor

zakjan commented Jul 21, 2021

Description of the functionality
Some examples on how to use the gem

I can update readme and add most common examples, does it help? Readme is obsolete anyway, I focused on the functionality and YARD docs, haven't touched readme at all yet.

Config/Configure is a remnant of the previous version, unfortunately I have no idea how it was supposed to be used. I can delete it.

How to traverse nodes and do things on encountering a parse node

The output from Parser.parse is Repository, all children can be traversed down. I'm not sure what more to add. I'll make sure there is an example in the readme.

Additional info on models ... Could we supplement this with the actual text from the document?

I can copy there the entire section text from PDF spec as-is, manually formatted. Is it ok to make it publicly available with your license? Alternatively, is there an online version of the spec to link to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants