Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colour whole screen with background instead of just the text #32

Open
landfillbaby opened this issue Jun 22, 2020 · 11 comments · May be fixed by #33
Open

colour whole screen with background instead of just the text #32

landfillbaby opened this issue Jun 22, 2020 · 11 comments · May be fixed by #33

Comments

@landfillbaby
Copy link
Contributor

landfillbaby commented Jun 22, 2020

i figured out a way to do it reliably using the "Erase in Line" control code but i've currently only implemented it as a standalone C program in my fork
need help on how to implement it as an option in the C++ version
i think maybe #31 should be merged first and renamed from "background" to "highlighting", or maybe just completely dropped if implementing both in 1 program gets too complicated

@obfusk
Copy link
Contributor

obfusk commented Jun 23, 2020

Unfortunately, urxvt doesn't redraw the background colour after the text when resizing the window :(

@landfillbaby
Copy link
Contributor Author

oh yeah, there's not really any good way to do that without using an external library to redraw everything

@obfusk
Copy link
Contributor

obfusk commented Jun 23, 2020

Bad choice of words: I meant it doesn't redraw the existing colours after the \n.
No terminal will "extend" the lines when resizing. Which is less of an issue.

@landfillbaby
Copy link
Contributor Author

oh, i see. oh well!!

@landfillbaby
Copy link
Contributor Author

i guess i should close this then?

@obfusk
Copy link
Contributor

obfusk commented Jun 23, 2020

Screenshot from 2020-06-23 11-46-11 cleaned
Screenshot from 2020-06-23 11-46-21 cleaned

@obfusk
Copy link
Contributor

obfusk commented Jun 23, 2020

I think this is a bug in urxvt; xterm seems fine.

@landfillbaby landfillbaby reopened this Jun 23, 2020
@landfillbaby
Copy link
Contributor Author

if xterm supports it that's good enough for me

@landfillbaby
Copy link
Contributor Author

landfillbaby commented Jun 23, 2020

wait, maybe it's because i originally used \033[2K and that's what you implemented too
i've since changed it to just \033[K, maybe you could try that on urxvt?

@obfusk
Copy link
Contributor

obfusk commented Jun 23, 2020

I already tried both.

@landfillbaby
Copy link
Contributor Author

oh ok. well at least it works on xterm

obfusk added a commit to obfusk/pridecat that referenced this issue Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants