Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block embeded video popup #25

Open
mtaki14 opened this issue Jan 17, 2021 · 5 comments
Open

Block embeded video popup #25

mtaki14 opened this issue Jan 17, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@mtaki14
Copy link

mtaki14 commented Jan 17, 2021

Sometimes this video player pops up while viewing your match history/ match stats. It would be nice if this was blocked

Blitz_u3ntlaH1KT

@lulzsun
Copy link
Owner

lulzsun commented Jan 17, 2021

If that ever happens again, try opening up developer tools (CTRL+SHIFT+I), get a copy of that element and paste it here. If you could do that, I'll get around adding a script to delete lingering ad elements such as this one.

This video popup rarely occurs for me so I haven't had a chance to copy it down or remember to do so before it disappears.

@lulzsun lulzsun added the enhancement New feature or request label Jan 17, 2021
@lulzsun
Copy link
Owner

lulzsun commented Jan 17, 2021

As I posted that comment, I managed to get a hold of the video element.

<div id="postmatch-video-container" class="VideoContainer-sc-4gcoyj-0 PakdA"></div>

Putting this here for reference when I get around adding a script to delete these types of elements.

@mtaki14
Copy link
Author

mtaki14 commented Jan 17, 2021

Great. Any idea what that actually is btw?

@lulzsun
Copy link
Owner

lulzsun commented Jan 17, 2021

I'm guessing it is leftover from an ad video that has been blocked, Blitz tries to pop up the video player but it won't play anything because of the ad filters.

Manually deleting it with developer tools causes Blitz to eventually crash because Blitz is also looking to delete the element. Unusual interaction, I'll find some time to look into this later.

@hazi98
Copy link

hazi98 commented Apr 28, 2021

Any updates into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants