Check if done, if not relevant leave unchecked.
- PR reference the relevant issue (e.g.
Fixes #007
orSee xoa-support#42
) - if UI changes, a screenshot has been added to the PR
- documentation updated
CHANGELOG.unreleased.md
:- enhancement/bug fix entry added
- list of packages to release updated (
${name} v${new version}
)
- I have tested added/updated features (and impacted code)
- unit tests (e.g.
cron/parse.spec.js
) - if
xo-server
API changes, the corresponding test has been added to/updated onxo-server-test
- at least manual testing
- unit tests (e.g.
- create a PR as soon as possible
- mark it as
WiP:
(Work in Progress) if not ready to be merged - when you want a review, add a reviewer (and only one)
- if necessary, update your PR, and re- add a reviewer
From the Four Agreements:
- Be impeccable with your word.
- Don't take anything personally.
- Don't make assumptions.
- Always do your best.