Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for palantir-java-format #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Machine-Maker
Copy link

Closes #1

@lukebemish
Copy link
Member

Thank you! One question I have -- how much of a fork, exactly, is the palantir java formatter? The wrapper and step involved there look really similar to that for the google formatter; is there any reason they can't share the same code in some places?

@lukebemish
Copy link
Member

On the flip side, it's also not that much code so no huge deal if there's some duplication, if combining stuff would introduce more complexity than it solves.

@Machine-Maker
Copy link
Author

Yeah, I thought about trying to re-use code, but it's really not a lot of code and if it ever does need to be different, maybe its better to just be separate.

@lukebemish
Copy link
Member

Fair enough. Lemme test it locally in the next few days, then I'll merge it. Thanks again for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for palantir-java-format
2 participants