How to add modded tools to the mining whitelist

[Advaera]

MC 1.21.1
Fabric 0.16.5
Excavated Variants 4.3.1

I'm running Excavated Variants alongside Easy Emerald Tools & More 1.8.17 and the mining tools that the mod added to the game are unable to mine blocks added by Excavated Variants. Are there tags that can be added to the configs or global resources that will allow excavated variants to be mined by specific modded tools?

Thanks!

[lukebemish]

The excavated variants blocks should use all the normal vanilla pickaxe tags. Either something about that setup isn't working -- you can try mining one with a vanilla pickaxe to check, if that doesn't work let me know -- or the other mod in question hasn't set up their mining tools right and there's nothing I can do about that

[Advaera]

Hey again!
I used the CraftTweaker mod and noticed that the blocks created by ExcavatedVariants in my game do not have any tags. In previous versions of Minecraft I used UniversalOres and generated blocks do list tags using the "/ct hand" command when a generated block is in hand.
I tried creating new blocks by creating some ore JSON files in the globalresources folder. I successfully created ores, but the tags I added still weren't added to the blocks even though I copied them from CraftTweaks. I tried several permutations of the tags but I still can't get any tags to show up in game.
What is the proper format of tags to get the tags to be added to generated blocks?
Thanks!

[lukebemish]

Hmm. The blocks should definitely have tags out of the box, if you're using the default configs -- can you share the full list of mods present and ideally a log? I'll take a look

[Advaera]

Ohh, yeah this is definitely interference from another mod. I've got a lot of mods so I grouped them out to try and find the problem and narrowed it down to the Tide fishing mod. So far in my testing it looks like anytime Tide is active then blocks created by Excavated Variants have no tags.

[Advaera]

I created a profile with as few mods as possible to test out what might be happening.

I'm down to:
Cloth Config API
CraftTweaker
Dynamic Asset Generator
Excavated Variants
Fabric API
Faux Custom Entity Data
Tide

I tested this in Minecraft 1.21 and 1.21.1 and found the same thing was happening in both versions. From what I can see, whenever Tide is enabled there's an error that pops up in the logs and then tags aren't loaded the way they're supposed to be:

[12:01:24] [Render thread/WARN]: Shader rendertype_entity_translucent_emissive could not find sampler named Sampler2 in the specified shader program.
[12:01:27] [Render thread/INFO]: Found new data pack tide, loading it automatically
[12:01:27] [Render thread/ERROR]: Issue setting up PathAwareInputStreamSource:
java.lang.NullPointerException: null
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?]
at java.base/java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1715) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?]
at dev.lukebemish.excavatedvariants.impl.MiningLevelTagHolder.getMiningLevels(MiningLevelTagHolder.java:35) ~[excavatedvariants-4.3.0-fabric.jar:?]
at dev.lukebemish.excavatedvariants.impl.MiningLevelTagHolder.apply(MiningLevelTagHolder.java:42) ~[excavatedvariants-4.3.0-fabric.jar:?]
at dev.lukebemish.excavatedvariants.impl.MiningLevelTagHolder.apply(MiningLevelTagHolder.java:28) ~[excavatedvariants-4.3.0-fabric.jar:?]
at dev.lukebemish.dynamicassetgenerator.api.sources.TagSupplier$TagBakery.lambda$checkTags$9(TagSupplier.java:141) ~[dynamicassetgenerator-6.1.1-fabric.jar:?]
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) ~[?:?]
at dev.lukebemish.dynamicassetgenerator.api.sources.TagSupplier$TagBakery.checkTags(TagSupplier.java:140) ~[dynamicassetgenerator-6.1.1-fabric.jar:?]
at dev.lukebemish.dynamicassetgenerator.api.sources.TagSupplier$TagBakery.apply(TagSupplier.java:152) ~[dynamicassetgenerator-6.1.1-fabric.jar:?]
at dev.lukebemish.excavatedvariants.impl.ExcavatedVariants$1.apply(ExcavatedVariants.java:159) ~[excavatedvariants-4.3.0-fabric.jar:?]
at dev.lukebemish.excavatedvariants.impl.ExcavatedVariants$1.apply(ExcavatedVariants.java:156) ~[excavatedvariants-4.3.0-fabric.jar:?]
at dev.lukebemish.dynamicassetgenerator.api.sources.TagSupplier$TagBakery.lambda$checkTags$9(TagSupplier.java:141) ~[dynamicassetgenerator-6.1.1-fabric.jar:?]
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) ~[?:?]
at dev.lukebemish.dynamicassetgenerator.api.sources.TagSupplier$TagBakery.checkTags(TagSupplier.java:140) ~[dynamicassetgenerator-6.1.1-fabric.jar:?]
at dev.lukebemish.dynamicassetgenerator.api.sources.TagSupplier$TagBakery.getLocations(TagSupplier.java:125) ~[dynamicassetgenerator-6.1.1-fabric.jar:?]
at dev.lukebemish.dynamicassetgenerator.api.ResourceCache.lambda$getResources$2(ResourceCache.java:93) ~[dynamicassetgenerator-6.1.1-fabric.jar:?]
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) ~[?:?]
at dev.lukebemish.dynamicassetgenerator.api.ResourceCache.getResources(ResourceCache.java:90) ~[dynamicassetgenerator-6.1.1-fabric.jar:?]
at dev.lukebemish.dynamicassetgenerator.impl.GeneratedPackResources.getStreams(GeneratedPackResources.java:39) ~[dynamicassetgenerator-6.1.1-fabric.jar:?]
at dev.lukebemish.dynamicassetgenerator.impl.GeneratedPackResources.method_14406(GeneratedPackResources.java:90) ~[dynamicassetgenerator-6.1.1-fabric.jar:?]
at net.minecraft.class_6861.method_41275(class_6861.java:31) ~[client-intermediary.jar:?]
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:273) ~[?:?]
at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:1024) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:575) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260) ~[?:?]
at java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:616) ~[?:?]
at java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:622) ~[?:?]
at java.base/java.util.stream.ReferencePipeline.toList(ReferencePipeline.java:627) ~[?:?]
at net.minecraft.class_6861.(class_6861.java:31) ~[client-intermediary.jar:?]
at net.minecraft.class_7237$class_7238.method_42099(class_7237.java:94) ~[client-intermediary.jar:?]
at net.minecraft.class_7237.method_42098(class_7237.java:27) ~[client-intermediary.jar:?]
at net.minecraft.class_7196.method_45694(class_7196.java:181) ~[client-intermediary.jar:?]
at net.minecraft.class_7196.method_54610(class_7196.java:137) ~[client-intermediary.jar:?]
at net.minecraft.class_7196.method_57780(class_7196.java:323) ~[client-intermediary.jar:?]
at net.minecraft.class_7196.method_57781(class_7196.java:313) ~[client-intermediary.jar:?]
at net.minecraft.class_7196.method_57782(class_7196.java:278) ~[client-intermediary.jar:?]
at net.minecraft.class_7196.method_57784(class_7196.java:243) ~[client-intermediary.jar:?]
at net.minecraft.class_528$class_4272.method_20164(class_528.java:434) ~[client-intermediary.jar:?]
at net.minecraft.class_528$class_4272.method_25402(class_528.java:411) ~[client-intermediary.jar:?]
at net.minecraft.class_350.method_25402(class_350.java:315) ~[client-intermediary.jar:?]
at net.minecraft.class_4069.method_25402(class_4069.java:38) ~[client-intermediary.jar:?]
at net.minecraft.class_312.method_1611(class_312.java:107) ~[client-intermediary.jar:?]
at net.minecraft.class_437.method_25412(class_437.java:431) ~[client-intermediary.jar:?]
at net.minecraft.class_312.method_1601(class_312.java:107) ~[client-intermediary.jar:?]
at net.minecraft.class_312.method_22686(class_312.java:196) ~[client-intermediary.jar:?]
at net.minecraft.class_1255.execute(class_1255.java:108) ~[client-intermediary.jar:?]
at net.minecraft.class_312.method_22684(class_312.java:196) ~[client-intermediary.jar:?]
at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43) [lwjgl-glfw-3.3.3.jar:?]
at org.lwjgl.system.JNI.invokeV(Native Method) ~[lwjgl-3.3.3.jar:?]
at org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3509) [lwjgl-glfw-3.3.3.jar:?]
at com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:184) [client-intermediary.jar:?]
at net.minecraft.class_310.method_1523(class_310.java:1310) [client-intermediary.jar:?]
at net.minecraft.class_310.method_1514(class_310.java:882) [client-intermediary.jar:?]
at net.minecraft.client.main.Main.main(Main.java:256) [client-intermediary.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) [fabric-loader-0.16.5.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.16.5.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.16.5.jar:?]

If you'd like to look at them, I'll attach my full logs with and without tide enabled.

NoTide.log
WithTide.log

I really appreciate you thinking about the issue and thank you much for any advice you can offer!

[Advaera]

Good news! I posted the issue in the Tide git as well and Lightning-64 had this to say:

So basically, the Excavated Variants mod goes through each "tier" that is ever created, such as iron, gold, diamond, wood, stone, etc. Tide creates one custom tier to use for the Blazing Swordfish item, because weapons require a custom tier to be created. Excavated variants goes through every tier and keeps track of the IncorrectBlocksForDrops assigned for each tier so that its ores can be properly created.

When I was making the mod, I set the IncorrectBlocksForDrops tag for the Blazing Swordfish tier to be null, because I thought it would never be used, as the property is only used by pickaxes. Excavated variants, however, uses this tag to use for its ore blocks, and will throw an error if this value doesn't exist! All I had to do is pass in an actual value for the IncorrectBlocksForDrops property for the Blazing Swordfish tier, and the bug is fixed.

So Lightning says a fix will be implemented in the next update to Tide to play friendly with Excavated Varients!

Thank you both for taking the time to think about the issue!

[lukebemish]

Thanks for getting back to me! That's something I hadn't anticipated coming up at all; I'll try to add a check to prevent that sort of issue on my end too.