Initialize with const fn #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysonsantos
reviewed
Mar 3, 2019
| lookup | ||
| }; | ||
| const fn h_lookup_table() -> [u64; 256] { | ||
| let mut lookup = [1; 256]; |
There was a problem hiding this comment.
Just out of curiosity, any reason to initialize it with 256 items instead of just 5?
There was a problem hiding this comment.
We are not converting the bases ACGT to a 2-bit representation, instead we keep it as char, which is u8 (and 2**8 = 256).
That said, we could return [u8; 256] instead, because the two places using the lookup table are doing a c as usize conversion:
https://github.com/luizirber/nthash/pull/6/files#diff-b4aea3e418ccdb71239b96952d9cddb6R47
https://github.com/luizirber/nthash/pull/6/files#diff-b4aea3e418ccdb71239b96952d9cddb6R56
update: Err, no, we can't return [u8; 256] because the values in the array are indeed u64, and the c as usize is necessary because indexing uses usize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Rust 1.33 we can use
const fnand avoidlazy_static(as pointed in #2 (comment) )