Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve route handling and effect cleanup in pages/_app.tsx #9

Open
coderabbitai bot opened this issue Oct 30, 2024 · 0 comments
Open

Improve route handling and effect cleanup in pages/_app.tsx #9

coderabbitai bot opened this issue Oct 30, 2024 · 0 comments
Assignees
@luigibarbato

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2024

Description

The current implementation in pages/_app.tsx has several potential issues:

  1. Direct access to location without checking for the window object.
  2. Missing cleanup function in the useEffect hook.
  3. Not using Next.js router for path detection.

References
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luigibarbato luigibarbato

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luigibarbato