Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the extrema module #60

Open
lucydot opened this issue May 31, 2023 · 0 comments
Open

Refactor the extrema module #60

lucydot opened this issue May 31, 2023 · 0 comments
Labels
maintenance Not quite a bug, but could be in the future...

Comments

@lucydot
Copy link
Owner

lucydot commented May 31, 2023

The extrema module is feeling pretty clunky!

An improvement might be to create a new Bandstructure class within extrema.py, with each of the functions in the module mapped to Bandstructure methods. Might also rename extrema.py to bandstructure.py.
@lucydot lucydot added the maintenance Not quite a bug, but could be in the future... label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Not quite a bug, but could be in the future...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucydot