Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reservation buffer necessary? #1

Open
birnam opened this issue May 17, 2019 · 1 comment
Open

reservation buffer necessary? #1

birnam opened this issue May 17, 2019 · 1 comment

Comments

@birnam
Copy link

birnam commented May 17, 2019

I'm pretty green in both PIC and C++, so this might be obvious and I just haven't figured it out.

Is line 24 in #3HEF main.c necessary?

char buffer[ HEF_BLOCKSIZE];

It's unused in the code, so the only thing I've been able to come up with is that it serves to reserve a chunk of memory that won't be used by the compiler. However this is what the --ROM option does. Which, if I'm correct so far, makes me think that buffer might be leftover code from an earlier iteration that didn't use --ROM.

@luciodj
Copy link
Owner

luciodj commented May 23, 2019

You are correct, that is dead code left in main.c after I refactored the example.
It does not serve any purpose and can be removed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants