Skip to content

Commit

Permalink
Fix the wrong version of rules_jvm_external being used
Browse files Browse the repository at this point in the history
We're on an old version of protobuf, which uses an old version of
rules_jvm_external. Because the protobuf dependency came before
rules_jvm_external in the WORKSPACE file we were ending up with the
wrong version.

A similar problem exists with stardoc, so it was also moved.
  • Loading branch information
jjudd committed Nov 13, 2024
1 parent 911e0cb commit 6e861e7
Show file tree
Hide file tree
Showing 8 changed files with 7,673 additions and 12,201 deletions.
82 changes: 41 additions & 41 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -21,29 +21,6 @@ load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")

bazel_skylib_workspace()

# Stardoc

http_archive(
name = "io_bazel_stardoc",
sha256 = "fabb280f6c92a3b55eed89a918ca91e39fb733373c81e87a18ae9e33e75023ec",
urls = [
"https://mirror.bazel.build/github.com/bazelbuild/stardoc/releases/download/0.7.1/stardoc-0.7.1.tar.gz",
"https://github.com/bazelbuild/stardoc/releases/download/0.7.1/stardoc-0.7.1.tar.gz",
],
)

load("@io_bazel_stardoc//:setup.bzl", "stardoc_repositories")

stardoc_repositories()

load("@io_bazel_stardoc//:deps.bzl", "stardoc_external_deps")

stardoc_external_deps()

load("@stardoc_maven//:defs.bzl", stardoc_pinned_maven_install = "pinned_maven_install")

stardoc_pinned_maven_install()

# com_github_bazelbuild_buildtools

buildtools_tag = "7.1.2"
Expand Down Expand Up @@ -82,24 +59,6 @@ go_rules_dependencies()

go_register_toolchains(version = "1.17")

# protobuf

protobuf_tag = "3.19.6"

protobuf_sha256 = "387e2c559bb2c7c1bc3798c4e6cff015381a79b2758696afcbf8e88730b47389"

http_archive(
name = "com_google_protobuf",
sha256 = protobuf_sha256,
strip_prefix = "protobuf-{}".format(protobuf_tag),
type = "zip",
url = "https://github.com/protocolbuffers/protobuf/archive/v{}.zip".format(protobuf_tag),
)

load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")

protobuf_deps()

# rules_java
http_archive(
name = "rules_java",
Expand Down Expand Up @@ -182,6 +141,47 @@ load("@annex_proto//:defs.bzl", annex_proto_pinned_maven_install = "pinned_maven

annex_proto_pinned_maven_install()

# Stardoc

http_archive(
name = "io_bazel_stardoc",
sha256 = "fabb280f6c92a3b55eed89a918ca91e39fb733373c81e87a18ae9e33e75023ec",
urls = [
"https://mirror.bazel.build/github.com/bazelbuild/stardoc/releases/download/0.7.1/stardoc-0.7.1.tar.gz",
"https://github.com/bazelbuild/stardoc/releases/download/0.7.1/stardoc-0.7.1.tar.gz",
],
)

load("@io_bazel_stardoc//:setup.bzl", "stardoc_repositories")

stardoc_repositories()

load("@io_bazel_stardoc//:deps.bzl", "stardoc_external_deps")

stardoc_external_deps()

load("@stardoc_maven//:defs.bzl", stardoc_pinned_maven_install = "pinned_maven_install")

stardoc_pinned_maven_install()

# protobuf

protobuf_tag = "3.19.6"

protobuf_sha256 = "387e2c559bb2c7c1bc3798c4e6cff015381a79b2758696afcbf8e88730b47389"

http_archive(
name = "com_google_protobuf",
sha256 = protobuf_sha256,
strip_prefix = "protobuf-{}".format(protobuf_tag),
type = "zip",
url = "https://github.com/protocolbuffers/protobuf/archive/v{}.zip".format(protobuf_tag),
)

load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")

protobuf_deps()

# rules_pkg

rules_pkg_version = "1.0.0"
Expand Down
538 changes: 300 additions & 238 deletions annex_2_12_install.json

Large diffs are not rendered by default.

11,814 changes: 4,271 additions & 7,543 deletions annex_install.json

Large diffs are not rendered by default.

483 changes: 203 additions & 280 deletions annex_proto_install.json

Large diffs are not rendered by default.

2,134 changes: 894 additions & 1,240 deletions annex_scalafmt_install.json

Large diffs are not rendered by default.

37 changes: 18 additions & 19 deletions tests/WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -22,24 +22,6 @@ load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")

bazel_skylib_workspace()

# protobuf

protobuf_tag = "3.19.6"

protobuf_sha256 = "387e2c559bb2c7c1bc3798c4e6cff015381a79b2758696afcbf8e88730b47389"

http_archive(
name = "com_google_protobuf",
sha256 = protobuf_sha256,
strip_prefix = "protobuf-{}".format(protobuf_tag),
type = "zip",
url = "https://github.com/protocolbuffers/protobuf/archive/v{}.zip".format(protobuf_tag),
)

load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")

protobuf_deps()

# rules_java
http_archive(
name = "rules_java",
Expand All @@ -53,7 +35,6 @@ load("@rules_java//java:repositories.bzl", "rules_java_dependencies")

rules_java_dependencies()


register_toolchains("//:repository_default_toolchain_21_definition")

local_repository(
Expand Down Expand Up @@ -117,6 +98,24 @@ load("@annex_proto//:defs.bzl", annex_proto_pinned_maven_install = "pinned_maven

annex_proto_pinned_maven_install()

# protobuf

protobuf_tag = "3.19.6"

protobuf_sha256 = "387e2c559bb2c7c1bc3798c4e6cff015381a79b2758696afcbf8e88730b47389"

http_archive(
name = "com_google_protobuf",
sha256 = protobuf_sha256,
strip_prefix = "protobuf-{}".format(protobuf_tag),
type = "zip",
url = "https://github.com/protocolbuffers/protobuf/archive/v{}.zip".format(protobuf_tag),
)

load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")

protobuf_deps()

load("@rules_scala_annex//rules:external.bzl", "scala_import_external")
load("@rules_scala_annex//rules:rules_scala.bzl", "emulate_rules_scala")

Expand Down
1,900 changes: 686 additions & 1,214 deletions tests/annex_test_2_12_install.json

Large diffs are not rendered by default.

2,886 changes: 1,260 additions & 1,626 deletions tests/annex_test_install.json

Large diffs are not rendered by default.

0 comments on commit 6e861e7

Please sign in to comment.