Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem in timesformer_pytorch.py #15

Open
Weizhongjin opened this issue May 10, 2021 · 2 comments
Open

problem in timesformer_pytorch.py #15

Weizhongjin opened this issue May 10, 2021 · 2 comments

Comments

@Weizhongjin
Copy link

start from line 182
video = rearrange(video, 'b f c (h p1) (w p2) -> b (f h w) (p1 p2 c)', p1 = p, p2 = p)
i think this should be
video = rearrange(video, 'b f c (hp p1) (wp p2) -> b (f hp wp) (p1 p2 c)', p1 = p, p2 = p)
@lucidrains
Copy link
Owner

I believe that is equivalent

@tcapelle
Copy link

yeah, variables are silent inside this type of expressions. You could call h or z and it doe snot matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lucidrains @tcapelle @Weizhongjin