-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): add deprecationReason and alias deprecation feature #1960
Conversation
My vote is to |
Any ideas as to what these options should be? |
// depracation-reasons.en.json
{
"alias.typo": "Renamed because of typo, use {name} instead.",
"icon.brand": "Brand icons have been deprecated and are due to be removed, we recommend using simpleicons.org instead, refer to https://github.com/lucide-icons/lucide/issues/670"
} |
I think i18n is a bit of an overkill, since all of our packages are in English, but I've implemented a rudimentary template function and converted the deprecation reason to an enumeration. (I meant options apart from these two, so that we are somewhat futureproof, but we can think about that later) |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice lovely work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about my unanswered pr comments?
They've now been addressed. |
closes #1957
What is the purpose of this pull request?
Description
When deprecating icons (looking at you, brand icons) or aliases, it is important to clearly mark the reason of deprecation as well as any steps the users should take, this PR adds the possibility to add the reason for deprecation to icons as well as the possibility to mark aliases as deprecated as per #1957
Before Submitting