Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add X-twitter Icon #1561

Closed
wants to merge 1 commit into from
Closed

Conversation

reatlat
Copy link

@reatlat reatlat commented Sep 14, 2023

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adding the X-twitter Icon, json schema and svg itself

Icon use case

Adding the X-twitter Icon to your website can improve its visibility and make it more recognizable. Visitors will be able to easily identify and connect with your brand, increasing engagement and potentially attracting more traffic.

Alternative icon designs

The eX Twitter Icon is an updated version of the classic Twitter bird logo. It brings a fresh look while still representing the familiar Twitter brand.

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Sep 14, 2023
@github-actions
Copy link

Added or changed icons

icons/x-twitter.svg

Preview cohesion icons/pen-square.svg
icons/x-twitter.svg
icons/clock-10.svg
Preview stroke widths icons/x-twitter.svg
icons/x-twitter.svg
icons/x-twitter.svg
DPI Preview (24px) icons/x-twitter.svg
Icon X-rays icons/x-twitter.svg

@reatlat
Copy link
Author

reatlat commented Sep 14, 2023

@karsa-mistmere, would you please explain, why don't you want to add the X icon to the library?
I really need it this icon on my project, and I want to keep all icons under Lucide,
Thanks

@karsa-mistmere
Copy link
Member

You have declared that this is not a brand icon, but it is in fact very much a brand icon.

We do not allow brand icons. #670

@richcahill
Copy link

Disappointed by this. If there's a Twitter icon, there should be an X icon.

@reatlat
Copy link
Author

reatlat commented Nov 29, 2023

@richcahill I guess short answer is, switch to modern library with open eyes 👀

@karsa-mistmere karsa-mistmere mentioned this pull request Apr 5, 2024
5 tasks
@karsa-mistmere karsa-mistmere mentioned this pull request May 22, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants