Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bot-2 icon #1544

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Add bot-2 icon #1544

merged 2 commits into from
Sep 8, 2023

Conversation

ericfennis
Copy link
Member

closes #934

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

This PR solves the issue of #934 for requesting a better bot icon. The current bot icon is not always best looking for the new area of AI Apps. Since my design got most of the thumbs ups, here the PR.

Icon use case

Ai generated content, same usecase as current bot icon

Alternative icon designs

See alternative designs in #934

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in Better robot icon #934 by @ericfennis
  • I've based them on the following Lucide icons: bot
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions.
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Aug 31, 2023
@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Added or changed icons

icons/bot.svg

Preview cohesion icons/user-square-2.svg
icons/bot.svg
icons/dice-4.svg
Preview stroke widths icons/bot.svg
icons/bot.svg
icons/bot.svg
DPI Preview (24px) icons/bot.svg
Icon X-rays icons/bot.svg

@ericfennis
Copy link
Member Author

This one violates the naming convention of using numbers for alternative icons.
I seriously don't know what alternative name we should use, suggestions are welcome!

@karsa-mistmere
Copy link
Member

This one violates the naming convention of using numbers for alternative icons. I seriously don't know what alternative name we should use, suggestions are welcome!

I don't think we should use any, but instead simply replace the existing robot icon.

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should use any, but instead simply replace the existing robot icon.

Strongly agree, otherwise 👍

icons/bot-2.json Outdated Show resolved Hide resolved
@ericfennis
Copy link
Member Author

@karsa-mistmere @jguddas Replaced it!

@karsa-mistmere karsa-mistmere merged commit 09d9bb7 into lucide-icons:main Sep 8, 2023
3 checks passed
@@ -1,7 +1,6 @@
{
"$schema": "../icon.schema.json",
"contributors": [
"mittalyashu",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because their entire contribution to this icon has essentially been removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better robot icon
3 participants