Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external option does not work with plain specifier #137

Open
eibens opened this issue Aug 25, 2024 · 0 comments
Open

external option does not work with plain specifier #137

eibens opened this issue Aug 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@eibens
Copy link

eibens commented Aug 25, 2024

#102 added support for marking specifiers as external, but it currently only works for specifiers such as foo:bar but not for a plain specifier such as bar.

The test for this indicates the possibility of marking bar as external, but does not actually test for this. If the test is extended to consider the bar import, like I did here, the test emits the following error:

✘ [ERROR] specifier was a bare specifier, but was not remapped to anything by importMap. [plugin deno-resolver]

    testdata/externals.ts:3:18:
      3 │ export { c } from "bar";
        ╵                   ~~~~~
@lucacasonato lucacasonato added the bug Something isn't working label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants