feature/add-currently-installed-package-versions #17

sbramley · 2017-12-05T05:24:51Z

First ever commit to open source :-O

Be gentle...

I've added a get contents method on the current composer.lock file, this should capture all the installed package versions then map them to the composer.json file so you can see not only what minimum requirements your package has, but what the currently installed version is as well.

Be gentle... I've added a get contents method on the current composer.lock file, this should capture all the installed package versions then map them to the composer.json file so you can see not only what minimum requirements your package has, but what the currently installed version is as well.

Nitpick-CI · 2017-12-05T05:24:59Z

src/Decomposer.php

+
+        // reformat packages for easy reference
+        $package_lock_details = [];
+        foreach($lock_file->packages as $the_package) {


Expected 1 space after FOREACH keyword; 0 found

introwit · 2017-12-05T06:41:45Z

@sbramley Hey thanks for the PR, it's great 🙂 Few nitpicks:

Use camelCasing for variable names instead of underscores.
Remove that comment saying // reformat packages for easy reference
Put a space after foreach keyword
Rename the_package variable to just package

introwit · 2017-12-05T06:44:04Z

src/views/index.blade.php

                            @foreach($packages as $package)
                                <tr>
-                                    <td>{{ $package['name'] }} : <span class="label ld-version-tag">{{ $package['version'] }}</span></td>
+                                    <td>{{ $package['name'] }} : <span class="label ld-version-tag">{{ $package['version'] }}</span> : <span class="label ld-version-tag">{{ $package['version-installed']->version }}</span> </td>


I guess only $package['version-installed'] would work. No need of ->version again at the end. Not sure, make sure you test it :) Will be adding tests to this package really soon

Hey mate, I'm actually taking the entire package object and passing it across, so you could effectively get more than the version:

"aws/aws-sdk-php" => {#716 ▼ +"name": "aws/aws-sdk-php" +"version": "3.40.0" +"source": {#721 ▶} +"dist": {#719 ▶} +"require": {#714 ▶} +"require-dev": {#724 ▶} +"suggest": {#720 ▶} +"type": "library" +"extra": {#725 ▶} +"autoload": {#727 ▶} +"notification-url": "https://packagist.org/downloads/" +"license": array:1 [▶] +"authors": array:1 [▶] +"description": "AWS SDK for PHP - Use Amazon Web Services in your PHP project" +"homepage": "http://aws.amazon.com/sdkforphp" +"keywords": array:8 [▶] +"time": "2017-11-27T09:20:45+00:00" }

I can pass just the version across if you prefer it that way, I normally lean to more info so it's easy to extend on.

…n for the composer.lock file should it not exist.

Nitpick-CI · 2017-12-05T17:40:09Z

src/Decomposer.php

@@ -133,6 +133,16 @@ public static function getComposerArray()

    public static function getPackagesAndDependencies($packagesArray)
    {
+		$packageLockDetails = [];


Spaces must be used to indent lines; tabs are not allowed

Nitpick-CI · 2017-12-05T17:40:10Z

src/Decomposer.php

@@ -133,6 +133,16 @@ public static function getComposerArray()

    public static function getPackagesAndDependencies($packagesArray)
    {
+		$packageLockDetails = [];
+		if(file_exists(base_path('composer.lock'))) {


Spaces must be used to indent lines; tabs are not allowed

Expected 1 space after IF keyword; 0 found

Nitpick-CI · 2017-12-05T17:40:10Z

src/Decomposer.php

@@ -133,6 +133,16 @@ public static function getComposerArray()

    public static function getPackagesAndDependencies($packagesArray)
    {
+		$packageLockDetails = [];
+		if(file_exists(base_path('composer.lock'))) {
+			$lockFile = json_decode(file_get_contents(base_path('composer.lock')));


Spaces must be used to indent lines; tabs are not allowed

Nitpick-CI · 2017-12-05T17:40:10Z

src/Decomposer.php

+		if(file_exists(base_path('composer.lock'))) {
+			$lockFile = json_decode(file_get_contents(base_path('composer.lock')));
+
+			$packageLockDetails = [];


Spaces must be used to indent lines; tabs are not allowed

Nitpick-CI · 2017-12-05T17:40:11Z

src/Decomposer.php

+			$lockFile = json_decode(file_get_contents(base_path('composer.lock')));
+
+			$packageLockDetails = [];
+			foreach ($lockFile->packages as $package) {


Spaces must be used to indent lines; tabs are not allowed

Nitpick-CI · 2017-12-05T17:40:11Z

src/Decomposer.php

+
+			$packageLockDetails = [];
+			foreach ($lockFile->packages as $package) {
+				$packageLockDetails[$package->name] = $package;


Spaces must be used to indent lines; tabs are not allowed

Nitpick-CI · 2017-12-05T17:40:12Z

src/Decomposer.php

+			$packageLockDetails = [];
+			foreach ($lockFile->packages as $package) {
+				$packageLockDetails[$package->name] = $package;
+			}


Spaces must be used to indent lines; tabs are not allowed

Nitpick-CI · 2017-12-05T17:40:12Z

src/Decomposer.php

+			foreach ($lockFile->packages as $package) {
+				$packageLockDetails[$package->name] = $package;
+			}
+		}


Spaces must be used to indent lines; tabs are not allowed

introwit · 2017-12-06T05:29:44Z

src/Decomposer.php

@@ -133,6 +133,16 @@ public static function getComposerArray()

    public static function getPackagesAndDependencies($packagesArray)
    {
+        $packageLockDetails = [];


The $packageLockDetails array is also initialized in the if loop below. We don't need to initialize it twice.

introwit · 2017-12-06T05:31:33Z

src/Decomposer.php

@@ -265,7 +276,7 @@ private static function checkSslIsInstalled()
    private static function folderSize($dir)
    {
        $size = 0;
-        foreach (glob(rtrim($dir, '/').'/*', GLOB_NOSORT) as $each) {
+        foreach (glob(rtrim($dir, '/') . '/*', GLOB_NOSORT) as $each) {


You may remove the spaces back, it looks clean that older way :)

introwit · 2017-12-06T05:32:18Z

src/views/index.blade.php

@@ -128,14 +128,15 @@
                        <table id="decomposer" class="table table-hover table-bordered">
                            <thead>
                                <tr>
-                                    <th>Package Name : Version</th>
+                                    <th>Package Name : Version : Version Installed</th>


You can make this Package name : Required version : Version installed

introwit · 2017-12-06T05:33:07Z

src/views/index.blade.php

                            @foreach($packages as $package)
                                <tr>
-                                    <td>{{ $package['name'] }} : <span class="label ld-version-tag">{{ $package['version'] }}</span></td>
+                                    <td>{{ $package['name'] }} : <span class="label ld-version-tag">{{ $package['version'] }}</span> : <span class="label ld-version-tag">{{ isset($package['version-installed']->version) ? $package['version-installed']->version : "N/A" }}</span> </td>


Based on the array above why $package['version-installed']->version I guess $package['version-installed'] should be enough?

introwit · 2017-12-06T05:34:45Z

@sbramley this looks neat :) Few final minor things, after that it's ready to be merged. Thank you for the contribution Sam 🙂

ajitbohra · 2018-02-13T12:48:50Z

@sbramley thanks for the PR, can you help us with the changes @introwit suggested and we are all good to merge it.

Nitpick-CI reviewed Dec 5, 2017

View reviewed changes

introwit reviewed Dec 5, 2017

View reviewed changes

Updated logic to match coding standards of package, added a wrapper i…

f79e6cb

…n for the composer.lock file should it not exist.

Nitpick-CI reviewed Dec 5, 2017

View reviewed changes

No tabs, only spaces.

37bda1a

introwit reviewed Dec 6, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature/add-currently-installed-package-versions #17

feature/add-currently-installed-package-versions #17

sbramley commented Dec 5, 2017

Nitpick-CI Dec 5, 2017

introwit commented Dec 5, 2017

introwit Dec 5, 2017

sbramley Dec 5, 2017

Nitpick-CI Dec 5, 2017

Nitpick-CI Dec 5, 2017

Nitpick-CI Dec 5, 2017

Nitpick-CI Dec 5, 2017

Nitpick-CI Dec 5, 2017

Nitpick-CI Dec 5, 2017

Nitpick-CI Dec 5, 2017

Nitpick-CI Dec 5, 2017

introwit Dec 6, 2017

introwit Dec 6, 2017

introwit Dec 6, 2017

introwit Dec 6, 2017

introwit commented Dec 6, 2017

ajitbohra commented Feb 13, 2018

feature/add-currently-installed-package-versions #17

Are you sure you want to change the base?

feature/add-currently-installed-package-versions #17

Conversation

sbramley commented Dec 5, 2017

Choose a reason for hiding this comment

introwit commented Dec 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

introwit commented Dec 6, 2017

ajitbohra commented Feb 13, 2018