From 0cb44c0c96e9a43d538453a42ceb6c3726127af1 Mon Sep 17 00:00:00 2001 From: RyanSquared Date: Wed, 14 Mar 2018 12:42:36 -0500 Subject: [PATCH 1/6] CONTRIBUTING: Initial Commit --- CONTRIBUTING.md | 73 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000..ecef201 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,73 @@ +# Contributing to the Lua Users Foundation + +This document serves as contribution guidelines and the points listed should be +followed for contributions to the foundation. + +## Commit Guidelines + +As is somewhat standard practice, the following should be observed: + +- The usage of Markdown-formatted lists is allowed +- Paragraphs should be broken with an empty line between +- Further lines after the header should be no more than 72 characters +- Further lines, if required, should contain detailed information on: + 1. Implications of the changes in the commit + 2. Reasons the changes are required + +Commits relating to one file should follow these guidelines: + +- The header line should be no more than 60 characters +- The header line should contain the filename and a short description of what +applying the patch will do, in the format of "If applied, this commit will..." +- The second line should be blank + +Example commit message: + +```markdown +CONTRIBUTING.md: Establish guidelines for new commits + +Implications of Changes: + +- Could possibly make it harder for outsiders to contribute +- Could create bloatware in the repository data + +Reasons for Changes: + +- Creates a structure which can be used to avoid excessive comments + during the review process +``` + +Commits relating to multiple files should follow these guidelines: + +- The header line should be no more than 50 characters +- The header line should contain a short description of what applying the patch +will do, in the format of "If applied, this commit will..." +- The second line should be blank +- The third line should begin a list of changed files, with a header along the +lines of "Changed Files:" + +Example commit message: + +```markdown +Apply changes to files as per guidelines + +Changed Files: +- README.md +- CONTRIBUTING.md + +Reasons for Changes: +- This is an example message, but anyways: The guidelines changed, so this + commit adapts the documents to follow the new guidelines as of 2018-03-14. +``` + + +## Document Design Guidelines + +Contributions to documents for the repository should follow these guidelines: + +- Lines should be no more than 80 characters +- Documents should be written using standard Markdown (try to avoid using +GitHub flavoring) +- Documents should use relative URLs when linking to other documents +- Links should use the format of putting a link at the bottom of the page if a +line breaks 80 characters From 65ec9958ef53e9b082c6de8855c1f0fabd61581c Mon Sep 17 00:00:00 2001 From: RyanSquared Date: Wed, 14 Mar 2018 13:01:32 -0500 Subject: [PATCH 2/6] README.md: Adapt to contribution guidelines --- README.md | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 0d25bf5..ef7f8be 100644 --- a/README.md +++ b/README.md @@ -1,14 +1,29 @@ # Lua Users Foundation -This is the main repository where the Lua community can collaborate in order to organise the foundation. +This is the main repository where the Lua community can collaborate in order to +organise the foundation. # What is the Lua Users Foundation -The Lua Users Foundation is an association of individuals in a modular umbrella structure with the mission of supporting and promoting the Lua programming language, its community and ecosystems. Please take check the current draft of our Manifesto for more details, or even collaborate to its definition. You can see our work in progress in the [Pull Requests](https://github.com/lua-users-foundation/foundation/pulls) of this repository. +The Lua Users Foundation is an association of individuals in a modular umbrella +structure with the mission of supporting and promoting the Lua programming +language, its community and ecosystems. Please take check the current draft of +our Manifesto for more details, or even collaborate to its definition. You can +see our work in progress in the [Pull Requests][pull-requests] of this +repository. # Who we are -The list of people involved with the foundation can be seen [here](https://github.com/orgs/lua-users-foundation/people). This list is currently being updated and also in the meantime there is a [discussion](https://github.com/lua-users-foundation/foundation/issues/1) on how to define membership of the foundation. +The list of people involved with the foundation can be seen [here][gh-org]. +This list is currently being updated and also in the meantime there is a +[discussion][issue-1] on how to define membership of the foundation. # Join us -Join us and collaborate in this initiave. The work will be conducted in this repository and we are also chatting about it at Slack. Click here to join our [Slack Channel](https://join.slack.com/t/lua-users-foundation/shared_invite/enQtMzMwMDQ2MTcwNzU4LTg1YmU1ZDg0ZGY0MGY2OTdhZjQ0YzZmNjAzNzdhMTZjNTdkMDNkOWNmZDlkMmZiNWQ0M2ZlNWQ4MGI5YjUxNzQ) +Join us and collaborate in this initiave. The work will be conducted in this +repository and we are also chatting about it at Slack. Click here to join our +[Slack Channel][slack-channel]. + +[pull-requests]: https://github.com/lua-users-foundation/foundation/pulls +[gh-org]: https://github.com/orgs/lua-users-foundation/people +[issue-1]: https://github.com/lua-users-foundation/foundation/issues/1 +[slack-channel]: https://join.slack.com/t/lua-users-foundation/shared_invite/enQtMzMwMDQ2MTcwNzU4LTg1YmU1ZDg0ZGY0MGY2OTdhZjQ0YzZmNjAzNzdhMTZjNTdkMDNkOWNmZDlkMmZiNWQ0M2ZlNWQ4MGI5YjUxNzQ From 1820878a2fd49da6d617e53ea9601824a3b7e070 Mon Sep 17 00:00:00 2001 From: RyanSquared Date: Thu, 15 Mar 2018 08:02:25 -0500 Subject: [PATCH 3/6] CONTRIBUTING: Add message for code of conduct --- CONTRIBUTING.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ecef201..ab21265 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -3,6 +3,8 @@ This document serves as contribution guidelines and the points listed should be followed for contributions to the foundation. +Contributions are expected to follow the [code of conduct](CODE_OF_CONDUCT.md). + ## Commit Guidelines As is somewhat standard practice, the following should be observed: From 8849cefbb545a16907dabf01b746fb03c316aadc Mon Sep 17 00:00:00 2001 From: RyanSquared Date: Thu, 15 Mar 2018 08:06:16 -0500 Subject: [PATCH 4/6] CONTRIBUTING: Request using imperative for Git commits --- CONTRIBUTING.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ab21265..dbf1978 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -10,6 +10,8 @@ Contributions are expected to follow the [code of conduct](CODE_OF_CONDUCT.md). As is somewhat standard practice, the following should be observed: - The usage of Markdown-formatted lists is allowed +- Commit messages should start with an imperative verb, to act as a description +of what applying the commit would do: "If applied, this commit will..." - Paragraphs should be broken with an empty line between - Further lines after the header should be no more than 72 characters - Further lines, if required, should contain detailed information on: From 5a329c860bbe44697e0f2b6961fc862e238b6d8b Mon Sep 17 00:00:00 2001 From: RyanSquared Date: Thu, 15 Mar 2018 08:06:45 -0500 Subject: [PATCH 5/6] CODE_OF_CONDUCT: Add placeholder file --- CODE_OF_CONDUCT.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 CODE_OF_CONDUCT.md diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md new file mode 100644 index 0000000..e69de29 From 1416b55278aaaec4ed3b4e2b14548c4ce43fb742 Mon Sep 17 00:00:00 2001 From: RyanSquared Date: Thu, 15 Mar 2018 09:20:28 -0500 Subject: [PATCH 6/6] CONTRIBUTING: Change line length to 60 for headers --- CONTRIBUTING.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index dbf1978..74c6942 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -10,7 +10,8 @@ Contributions are expected to follow the [code of conduct](CODE_OF_CONDUCT.md). As is somewhat standard practice, the following should be observed: - The usage of Markdown-formatted lists is allowed -- Commit messages should start with an imperative verb, to act as a description +- The header line should be no more than 60 characters +- Commit headers should start with an imperative verb, to act as a description of what applying the commit would do: "If applied, this commit will..." - Paragraphs should be broken with an empty line between - Further lines after the header should be no more than 72 characters @@ -20,7 +21,6 @@ of what applying the commit would do: "If applied, this commit will..." Commits relating to one file should follow these guidelines: -- The header line should be no more than 60 characters - The header line should contain the filename and a short description of what applying the patch will do, in the format of "If applied, this commit will..." - The second line should be blank @@ -43,7 +43,6 @@ Reasons for Changes: Commits relating to multiple files should follow these guidelines: -- The header line should be no more than 50 characters - The header line should contain a short description of what applying the patch will do, in the format of "If applied, this commit will..." - The second line should be blank