Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Bootstrap to 5.3 #837

Merged
merged 8 commits into from
Feb 22, 2024
Merged

Upgrade Bootstrap to 5.3 #837

merged 8 commits into from
Feb 22, 2024

Conversation

coudot
Copy link
Member

@coudot coudot commented Feb 16, 2024

Fix #834

@coudot coudot added enhancement dependencies Pull requests that update a dependency file labels Feb 16, 2024
@coudot coudot added this to the 1.6.0 milestone Feb 16, 2024
@coudot
Copy link
Member Author

coudot commented Feb 16, 2024

@davidcoutadeur you need to run composer update to get the new bootstrap version

@davidcoutadeur
Copy link

I have just removed bootstrap-theme.min.css inclusion, as it seems to have been removed in bootstrap 5.3

davidcoutadeur
davidcoutadeur reviewed Feb 22, 2024
View reviewed changes
Copy link

@davidcoutadeur davidcoutadeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some basics tests.
Seems all fine to me.

@coudot coudot merged commit 4ab4d9a into master Feb 22, 2024
1 check passed
@coudot coudot deleted the 834-update-bootstrap branch February 22, 2024 17:23
@coudot
Copy link
Member Author

coudot commented Feb 22, 2024

Perfect, thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcoutadeur davidcoutadeur davidcoutadeur left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Update bootstrap library
2 participants
@coudot @davidcoutadeur