From 8400e9e96a6b7f13f1d46ee5f1910288895eb130 Mon Sep 17 00:00:00 2001
From: Lev Stipakov <lev@openvpn.net>
Date: Tue, 17 May 2022 16:28:45 +0300
Subject: [PATCH] Remove NetAdapterStop() call

This breaks on Windows 10 when called from EvtCleanupCallback
and looks like it doesn't even required - device got deleted
and verifier doesn't bark.

Bump version to 0.7.3

Signed-off-by: Lev Stipakov <lev@openvpn.net>
---
 PropertySheet.props | 2 +-
 adapter.cpp         | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/PropertySheet.props b/PropertySheet.props
index 0c77494..3e80690 100644
--- a/PropertySheet.props
+++ b/PropertySheet.props
@@ -4,7 +4,7 @@
   <PropertyGroup Label="UserMacros">
     <OVPN_DCO_VERSION_MAJOR>0</OVPN_DCO_VERSION_MAJOR>
     <OVPN_DCO_VERSION_MINOR>7</OVPN_DCO_VERSION_MINOR>
-    <OVPN_DCO_VERSION_PATCH>2</OVPN_DCO_VERSION_PATCH>
+    <OVPN_DCO_VERSION_PATCH>3</OVPN_DCO_VERSION_PATCH>
   </PropertyGroup>
   <PropertyGroup />
   <ItemDefinitionGroup>
diff --git a/adapter.cpp b/adapter.cpp
index 83a9eca..5e9f1f6 100644
--- a/adapter.cpp
+++ b/adapter.cpp
@@ -119,7 +119,9 @@ OvpnAdapterDestroy(NETADAPTER netAdapter)
     device->Adapter = WDF_NO_HANDLE;
     ExReleaseSpinLockExclusive(&device->SpinLock, irql);
 
-    NetAdapterStop(netAdapter);
+    // TODO: this breaks on Windows 10 when called from EvtCleanupCallback, is this call even needed?
+    // NetAdapterStop(netAdapter);
+
     WdfObjectDelete(netAdapter);
 }