Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noise realizations should also be sequence of MaskedImage #22

Open
esheldon opened this issue Aug 30, 2023 · 1 comment
Open

Noise realizations should also be sequence of MaskedImage #22

esheldon opened this issue Aug 30, 2023 · 1 comment

Comments

@esheldon
Copy link

def noise_realizations(self) -> Sequence[ImageF]:

They use the same variance and mask as the image.

I think this can be accomplished by making do something like this:

return [MaskedImageF(noise, self.mask, self.variance) for noise in self.noise_images]

Is the PSF already set in the ImageF?

@TallJimbo
Copy link
Member

That list comprehension is fine, and we could add it as a new property, e.g. noise_realizations_with_mask_and_variance (naming is hard). I would like to keep the original as a clearer representation of what's actually stored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants