From dd05f8eb8a94f55abf3e5f01964cb5fc053278a1 Mon Sep 17 00:00:00 2001 From: Dan Fuchs Date: Wed, 8 Jan 2025 15:42:49 -0600 Subject: [PATCH] review feedback --- applications/mobu/README.md | 2 +- .../mobu/tests/github_ci_app_enabled_test.yaml | 2 +- applications/mobu/tests/github_disabled_test.yaml | 2 +- .../mobu/tests/github_refresh_app_enabled_test.yaml | 2 +- applications/mobu/values.yaml | 10 ++++++---- 5 files changed, 10 insertions(+), 8 deletions(-) diff --git a/applications/mobu/README.md b/applications/mobu/README.md index 78522c83b0..58065a9d89 100644 --- a/applications/mobu/README.md +++ b/applications/mobu/README.md @@ -14,7 +14,7 @@ Continuous integration testing |-----|------|---------|-------------| | affinity | object | `{}` | Affinity rules for the mobu frontend pod | | config.autostart | list | `[]` | Autostart specification. Must be a list of mobu flock specifications. Each flock listed will be automatically started when mobu is started. | -| config.available_services | list | `[]` | Which applications (tap, butler, etc.) are available in this environment. Notebooks can specify a `mobu.required_services` list in their metadata, and mobu will only run them if all services in that list are in this `available_services` list. See https://mobu.lsst.io/user_guide/in_repo_config.html#service-specific-notebooks | +| config.availableServices | list | `[]` | Which applications (tap, butler, etc.) are available in this environment. Notebooks can specify a `mobu.required_services` list in their metadata, and mobu will only run them if all services in that list are in this `availableServices` list. See https://mobu.lsst.io/user_guide/in_repo_config.html#service-specific-notebooks | | config.githubCiApp | string | disabled. | Configuration for the GitHub CI app integration. See https://mobu.lsst.io/operations/github_ci_app.html#add-phalanx-configuration | | config.githubRefreshApp | string | disabled. | Configuration for the GitHub refresh app integration. See https://mobu.lsst.io/operations/github_refresh_app.html#add-phalanx-configuration | | config.logLevel | string | `"INFO"` | Log level. Set to 'DEBUG' to include the output from all flocks in the main mobu log. | diff --git a/applications/mobu/tests/github_ci_app_enabled_test.yaml b/applications/mobu/tests/github_ci_app_enabled_test.yaml index db5bfb35d8..71d655b111 100644 --- a/applications/mobu/tests/github_ci_app_enabled_test.yaml +++ b/applications/mobu/tests/github_ci_app_enabled_test.yaml @@ -52,7 +52,7 @@ tests: path: "data['config.yaml']" value: | autostart: [] - available_services: [] + availableServices: [] githubCiApp: acceptedGithubOrgs: - org1 diff --git a/applications/mobu/tests/github_disabled_test.yaml b/applications/mobu/tests/github_disabled_test.yaml index ab03885392..e93b49a2f4 100644 --- a/applications/mobu/tests/github_disabled_test.yaml +++ b/applications/mobu/tests/github_disabled_test.yaml @@ -14,7 +14,7 @@ tests: path: "data['config.yaml']" value: | autostart: [] - available_services: [] + availableServices: [] githubCiApp: null githubRefreshApp: null logLevel: INFO diff --git a/applications/mobu/tests/github_refresh_app_enabled_test.yaml b/applications/mobu/tests/github_refresh_app_enabled_test.yaml index ae5e4e830b..4ca3ae67a2 100644 --- a/applications/mobu/tests/github_refresh_app_enabled_test.yaml +++ b/applications/mobu/tests/github_refresh_app_enabled_test.yaml @@ -36,7 +36,7 @@ tests: path: "data['config.yaml']" value: | autostart: [] - available_services: [] + availableServices: [] githubCiApp: null githubRefreshApp: acceptedGithubOrgs: diff --git a/applications/mobu/values.yaml b/applications/mobu/values.yaml index 4c213f0175..0be48a6605 100644 --- a/applications/mobu/values.yaml +++ b/applications/mobu/values.yaml @@ -22,10 +22,12 @@ ingress: annotations: {} config: - # -- Which applications (tap, butler, etc.) are available in this environment. - # Notebooks can specify a `mobu.required_services` list in their metadata, and mobu will only run them if all services in that list are in this `available_services` list. - # See https://mobu.lsst.io/user_guide/in_repo_config.html#service-specific-notebooks - available_services: [] + # -- Which applications (tap, butler, etc.) are available in this + # environment. Notebooks can specify a `mobu.required_services` list in their + # metadata, and mobu will only run them if all services in that list are in + # this `availableServices` list. See + # https://mobu.lsst.io/user_guide/in_repo_config.html#service-specific-notebooks + availableServices: [] # -- Autostart specification. Must be a list of mobu flock specifications. # Each flock listed will be automatically started when mobu is started.