From 956c61c67fdf62d21bfff84abd652137c7b64795 Mon Sep 17 00:00:00 2001 From: Eric Rosas Date: Mon, 8 Jul 2024 09:44:15 -0700 Subject: [PATCH 1/3] Updated to `mhitza/flake8-jupyter-notebook@v1.3` Updated to `mhitza/flake8-jupyter-notebook@v1.3` for `ignore` feature --- .github/workflows/validate-flake8.yaml | 5 +++-- ...Tutorial.ipynbx => Citizen_Science_Butler_Tutorial.ipynb} | 0 ...S_Tutorial.ipynbx => Citizen_Science_HiPS_Tutorial.ipynb} | 0 ..._Science_Tabular.ipynbx => Citizen_Science_Tabular.ipynb} | 0 4 files changed, 3 insertions(+), 2 deletions(-) rename experimental_notebooks/{Citizen_Science_Butler_Tutorial.ipynbx => Citizen_Science_Butler_Tutorial.ipynb} (100%) rename experimental_notebooks/{Citizen_Science_HiPS_Tutorial.ipynbx => Citizen_Science_HiPS_Tutorial.ipynb} (100%) rename experimental_notebooks/{Citizen_Science_Tabular.ipynbx => Citizen_Science_Tabular.ipynb} (100%) diff --git a/.github/workflows/validate-flake8.yaml b/.github/workflows/validate-flake8.yaml index 410cca2..823c92b 100644 --- a/.github/workflows/validate-flake8.yaml +++ b/.github/workflows/validate-flake8.yaml @@ -32,9 +32,10 @@ jobs: uses: actions/checkout@v3 - name: Validate notebooks - uses: mhitza/flake8-jupyter-notebook@v1.2 + uses: mhitza/flake8-jupyter-notebook@v1.3 with: - args: --exclude=experimental_notebooks/** + ignore: | + experimental_notebooks/ validate-py-scripts: name: Py Scripts diff --git a/experimental_notebooks/Citizen_Science_Butler_Tutorial.ipynbx b/experimental_notebooks/Citizen_Science_Butler_Tutorial.ipynb similarity index 100% rename from experimental_notebooks/Citizen_Science_Butler_Tutorial.ipynbx rename to experimental_notebooks/Citizen_Science_Butler_Tutorial.ipynb diff --git a/experimental_notebooks/Citizen_Science_HiPS_Tutorial.ipynbx b/experimental_notebooks/Citizen_Science_HiPS_Tutorial.ipynb similarity index 100% rename from experimental_notebooks/Citizen_Science_HiPS_Tutorial.ipynbx rename to experimental_notebooks/Citizen_Science_HiPS_Tutorial.ipynb diff --git a/experimental_notebooks/Citizen_Science_Tabular.ipynbx b/experimental_notebooks/Citizen_Science_Tabular.ipynb similarity index 100% rename from experimental_notebooks/Citizen_Science_Tabular.ipynbx rename to experimental_notebooks/Citizen_Science_Tabular.ipynb From 7d1b87de267e61d224db11294e670c2f9048d091 Mon Sep 17 00:00:00 2001 From: beckynevin Date: Tue, 9 Jul 2024 22:00:05 +0000 Subject: [PATCH 2/3] importing fake package in 01 and utils to test flake8 --- 01_Introduction_to_Citsci_Pipeline.ipynb | 1 + utils.py | 1 + 2 files changed, 2 insertions(+) diff --git a/01_Introduction_to_Citsci_Pipeline.ipynb b/01_Introduction_to_Citsci_Pipeline.ipynb index 7a78403..4e6f790 100644 --- a/01_Introduction_to_Citsci_Pipeline.ipynb +++ b/01_Introduction_to_Citsci_Pipeline.ipynb @@ -131,6 +131,7 @@ "import utils\n", "import os\n", "import pandas as pd\n", + "import fake.package\n", "\n", "plt.style.use('tableau-colorblind10')" ] diff --git a/utils.py b/utils.py index 866ab83..4bce71e 100644 --- a/utils.py +++ b/utils.py @@ -7,6 +7,7 @@ import warnings import pandas as pd import numpy as np +import fake.package # Astropy imports from astropy.wcs import WCS From d88b9f530531a672029ab27b252f281717ea572f Mon Sep 17 00:00:00 2001 From: beckynevin Date: Tue, 9 Jul 2024 22:02:06 +0000 Subject: [PATCH 3/3] removing flake8 violations from utils and 01 --- 01_Introduction_to_Citsci_Pipeline.ipynb | 1 - utils.py | 1 - 2 files changed, 2 deletions(-) diff --git a/01_Introduction_to_Citsci_Pipeline.ipynb b/01_Introduction_to_Citsci_Pipeline.ipynb index 4e6f790..7a78403 100644 --- a/01_Introduction_to_Citsci_Pipeline.ipynb +++ b/01_Introduction_to_Citsci_Pipeline.ipynb @@ -131,7 +131,6 @@ "import utils\n", "import os\n", "import pandas as pd\n", - "import fake.package\n", "\n", "plt.style.use('tableau-colorblind10')" ] diff --git a/utils.py b/utils.py index 4bce71e..866ab83 100644 --- a/utils.py +++ b/utils.py @@ -7,7 +7,6 @@ import warnings import pandas as pd import numpy as np -import fake.package # Astropy imports from astropy.wcs import WCS