Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we hide the user/group block when permission set to attribute in windows #1018

Open
1 task done
Jaehaks opened this issue Mar 25, 2024 · 4 comments
Open
1 task done
Assignees

Comments

@Jaehaks
Copy link

Jaehaks commented Mar 25, 2024

Version

  • latest

version

v1.1.1

What OS are you seeing the problem on?

Windows

installation

scoop install lsd

term

windows terminal : cmd.exe

ls-colors

no

What happened?

if I set permission = rwx in config.yaml, 
It has delay to show result under any other lsd command
like lsd -al, lsd, etc.. except of lsd --version.
Delay is about 3~4s.

What expected?

there are not much delay between permission settings

What else?

No response

@Jaehaks
Copy link
Author

Jaehaks commented Mar 25, 2024

Plus, If I set permission = attribute, it works so fast but it dose not show user/group name . It shows just "?" characters

@zwpaper
Copy link
Member

zwpaper commented Mar 25, 2024

Hi @Jaehaks thanks for the report, this is known and as a workaround for the windows users, please check #911, and #200

as for the questioned user and group, please use config.yaml to hide the user and group blocks.

but for user ux, maybe we should hide the user/group by default for windows users?

@zwpaper
Copy link
Member

zwpaper commented Mar 25, 2024

let me change the title and we can discuss the hiding user/group, leave the performance to #378

/retitle should we hide the user/group block when permission set to attribute in windows

@zwpaper zwpaper changed the title [Bug]: lsd too slow when permission is set to 'rwx' in windows should we hide the user/group block when permission set to attribute in windows Mar 25, 2024
@yorah
Copy link

yorah commented Oct 5, 2024

but for user ux, maybe we should hide the user/group by default for windows users?

Took me some time to find the relevant issue when investigating those question marks. Hiding uiser/group block when permission is set to attribute (which is the default on windows) seem like the right thing to do from an ux perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants