Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: Replace snake_case with camelCase #68

Open
FelixTJDietrich opened this issue Aug 10, 2023 · 0 comments
Open

Playground: Replace snake_case with camelCase #68

FelixTJDietrich opened this issue Aug 10, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@FelixTJDietrich
Copy link
Collaborator

FelixTJDietrich commented Aug 10, 2023

Motivation

Athena now also supports camelCase so we can change most of the properties in the Playground to this instead of snake_case. This is mostly for consistency reasons and for sticking more to a JS/TS programming style.

Description

Change all occurrences in the Playground from snake_case to camelCase, including the example data and the data export scripts, i.e. SQL query (?) (open for discussion).

Context:

Ah, I see: The problem is that our data models in TS also have underscores. Maybe we should do a PR in the future where we generally change this, considering that Athena now also accepts camelCase input values

Originally posted by @pal03377 in #61 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants