Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion of inactive users does not work if too many users are inactive #9364

Closed
dfuchss opened this issue Sep 25, 2024 · 3 comments · Fixed by #9430
Closed

Deletion of inactive users does not work if too many users are inactive #9364

dfuchss opened this issue Sep 25, 2024 · 3 comments · Fixed by #9430
Assignees
Labels

Comments

@dfuchss
Copy link
Contributor

dfuchss commented Sep 25, 2024

Describe the bug

In #9224 we got the nice feature of deleting inactive users. Nevertheless, this request fails if you want to delete many users (e.g. > 1000).

Http failure response for https://artemis/api/admin/users?login=xyz&login=.....: 400 OK

It's probably because the request is encoded as parameters in the url.

To Reproduce

See above

Expected behavior

Inactive users shall be deleted

Screenshots

No response

Which version of Artemis are you seeing the problem on?

7.5.3

What browsers are you seeing the problem on?

Firefox

Additional context

No response

Relevant log output

No response

@dfuchss dfuchss added the bug label Sep 25, 2024
@b-fein
Copy link
Contributor

b-fein commented Sep 25, 2024

/cc @BaumiCoder

If the cause is the parameter list, I think a simple fix would then be to create a small DTO like

record InactiveUserLogins(logins: List<String>) {}

and send that as POST body rather than via parameters.

@dfuchss
Copy link
Contributor Author

dfuchss commented Sep 25, 2024

It's not super urgent because I've now used a script for that. But maybe it's important for others as well :)

-> kit-sdq/artemis4j@34b1cb9

@BaumiCoder
Copy link
Contributor

I can reproduce the bug. I get an even clearer error message:

Http failure response for http://localhost:9000/api/admin/users?login=dummy_user1000&login=dummy_user1001&... : 431 Request Header Fields Too Large

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants