Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Programming exercises: Scrolling position does not persist over a file switch in the online editor #8402

Open
BaumiCoder opened this issue Apr 15, 2024 · 3 comments · May be fixed by #10053
Open

Programming exercises: Scrolling position does not persist over a file switch in the online editor #8402

BaumiCoder opened this issue Apr 15, 2024 · 3 comments · May be fixed by #10053
Assignees
@chrisknedl
Labels
bug component:Programming

Comments

@BaumiCoder
Copy link
Contributor

Describe the bug

When I use the new online editor (Monaco) the scrolling position of the editor is always on the top of a file after opening it. I would expect that the previous scrolling position be retained for each file.

This problem applies to online editor for student submission (#8130) and for the online editor for instructors (#8389). Technically it should be quite the same situation.

To Reproduce

Example for the student submisson:

  1. Go to a Programming Exercise that allows the usage of the online editor for submissions.
  2. Open the exercise with the online editor
  3. Open a file (lets call this file1)
  4. Scroll down some lines
  5. Switch to another file
  6. Switch back to file1

Expected behavior

The editor is still in the scrolling position from step 4.

Screenshots

The editor is again at the top of the file.

Which version of Artemis are you seeing the problem on?

7.0.0

What browsers are you seeing the problem on?

Firefox

Additional context

The situation in the online editor for instructors (#8389) was tested with the branch feature/programming-exercises/monaco-instructors at Commit 25d4fe5.

Relevant log output

No response
@BaumiCoder BaumiCoder changed the title Programming exercises: Scrolling position does not persist over a file switch Programming exercises: Scrolling position does not persist over a file switch in the online editor Apr 15, 2024
@BaumiCoder
Copy link
Contributor Author

A similar problem with the old online editor was reported in #7393.

@pzdr7 pzdr7 self-assigned this Apr 15, 2024
@pzdr7
Copy link
Contributor

pzdr7 commented Apr 15, 2024

Thanks for reporting - I'll have a look

@pzdr7
Copy link
Contributor

pzdr7 commented Apr 15, 2024 •
edited
Loading

There are two underlying problems:

  • setting the cursor position does not scroll it into view (and the editor is not focused when you select a different file)
  • we're not updating the stored cursor position at the correct moment (needs to happen when we switch files, rather than when the file is modified)

I think Monaco provides a nice solution for this. There's a method saveViewState that stores the current position of the editor, its scroll position (among other things) and returns an object containing this information. Instead of manually restoring the cursor position, we could try saving and restoring the view state of the editor instead.

We'll have to see how this interacts with the feedback widgets rendered in the editor, though

(Edit: after trying it locally - the widgets do cause problems here, as they are rendered just a little bit later than the rest of the editor. we'll have to be careful about when to restore the view state of the editor)

@b-fein b-fein mentioned this issue Aug 25, 2024
Closed
@pzdr7 pzdr7 removed their assignment Nov 4, 2024
@chrisknedl chrisknedl linked a pull request Dec 19, 2024 that will close this issue
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisknedl chrisknedl

Labels
bug component:Programming
Projects
None yet
Milestone
No milestone
3 participants
@pzdr7 @chrisknedl @BaumiCoder