From 02f679816a80956d2c4a2d9147fa7872d093eb83 Mon Sep 17 00:00:00 2001 From: Murad Talibov Date: Sun, 15 Dec 2024 17:47:17 +0100 Subject: [PATCH] Avoid modifying server url on all git submission tests --- docker/playwright-E2E-tests-mysql-localci.yml | 2 ++ .../programming/ProgrammingExerciseParticipation.spec.ts | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/docker/playwright-E2E-tests-mysql-localci.yml b/docker/playwright-E2E-tests-mysql-localci.yml index cf677b01fec6..13d2ba3b00ef 100644 --- a/docker/playwright-E2E-tests-mysql-localci.yml +++ b/docker/playwright-E2E-tests-mysql-localci.yml @@ -47,6 +47,8 @@ services: condition: service_healthy environment: PLAYWRIGHT_DB_TYPE: 'MySQL' + network_mode: service:artemis-app + networks: !reset [] networks: artemis: diff --git a/src/test/playwright/e2e/exercise/programming/ProgrammingExerciseParticipation.spec.ts b/src/test/playwright/e2e/exercise/programming/ProgrammingExerciseParticipation.spec.ts index 09857e421a57..15fd2a784c8a 100644 --- a/src/test/playwright/e2e/exercise/programming/ProgrammingExerciseParticipation.spec.ts +++ b/src/test/playwright/e2e/exercise/programming/ProgrammingExerciseParticipation.spec.ts @@ -278,9 +278,6 @@ async function makeGitExerciseSubmission( await programmingExerciseOverview.openCloneMenu(cloneMethod); } let repoUrl = await programmingExerciseOverview.copyCloneUrl(); - if (process.env.CI === 'true' && (cloneMethod == GitCloneMethod.https || cloneMethod == GitCloneMethod.ssh)) { - repoUrl = repoUrl.replace(/(?<=@).+(?=:)/, 'artemis-app'); - } if (cloneMethod == GitCloneMethod.https) { repoUrl = repoUrl.replace(student.username!, `${student.username!}:${student.password!}`); }