Skip to content

Development: Test VSCode plugin support #59364

Development: Test VSCode plugin support

Development: Test VSCode plugin support #59364

GitHub Actions / Java Architecture Tests failed Sep 27, 2024 in 0s

50 passed, 1 failed and 3 skipped

Tests failed

Report Passed Failed Skipped Time
build/test-results/test/TEST-de.tum.cit.aet.artemis.architecture.ArchitectureTest.xml 19✅ 1⚪ 4s
build/test-results/test/TEST-de.tum.cit.aet.artemis.architecture.EnforceRoleInResourceArchitectureTest.xml 2✅ 268ms
build/test-results/test/TEST-de.tum.cit.aet.artemis.architecture.FeedbackArchitectureTest.xml 2✅ 432ms
build/test-results/test/TEST-de.tum.cit.aet.artemis.architecture.RepositoryArchitectureTest.xml 11✅ 344ms
build/test-results/test/TEST-de.tum.cit.aet.artemis.architecture.ResourceArchitectureTest.xml 4✅ 73ms
build/test-results/test/TEST-de.tum.cit.aet.artemis.architecture.ServiceArchitectureTest.xml 5✅ 181ms
build/test-results/test/TEST-de.tum.cit.aet.artemis.authorization.AuthorizationArchitectureTest.xml 5✅ 1❌ 2⚪ 51ms
build/test-results/test/TEST-de.tum.cit.aet.artemis.domain.notification.NotificationPlaceholderArchitectureTest.xml 2✅ 37ms

✅ build/test-results/test/TEST-de.tum.cit.aet.artemis.architecture.ArchitectureTest.xml

20 tests were completed in 4s with 19 passed, 0 failed and 1 skipped.

Test suite Passed Failed Skipped Time
de.tum.cit.aet.artemis.architecture.ArchitectureTest 19✅ 1⚪ 4s

✅ de.tum.cit.aet.artemis.architecture.ArchitectureTest

✅ ensureSpringComponentsAreProfileAnnotated()
✅ testNoJunitJupiterAssertions()
✅ hasMatchingAuthorizationTestClassBeCorrectlyImplemented()
✅ testFileWriteUsage()
✅ testCorrectStringUtils()
✅ testValidSimpMessageSendingOperationsUsage()
✅ testLogging()
✅ testNoHazelcastUsageInConstructors()
✅ testJSONImplementations()
✅ testNoRestControllersImported()
✅ testNoDirectGitCommitCalls()
✅ testNoCollectorsToList()
✅ testClassNameAndVisibility()
✅ testGsonExclusion()
✅ testNoJUnit4()
⚪ testDTOImplementations()
✅ shouldNotUserAutowiredAnnotation()
✅ testCorrectLoggerFields()
✅ testJsonIncludeNonEmpty()
✅ testNullnessAnnotations()

✅ build/test-results/test/TEST-de.tum.cit.aet.artemis.architecture.EnforceRoleInResourceArchitectureTest.xml

2 tests were completed in 268ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.cit.aet.artemis.architecture.EnforceRoleInResourceArchitectureTest 2✅ 268ms

✅ de.tum.cit.aet.artemis.architecture.EnforceRoleInResourceArchitectureTest

✅ testEnforceRoleInExerciseEndpointHasExerciseIdParameter()
✅ testEnforceRoleInCourseEndpointHasCourseIdParameter()

✅ build/test-results/test/TEST-de.tum.cit.aet.artemis.architecture.FeedbackArchitectureTest.xml

2 tests were completed in 432ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.cit.aet.artemis.architecture.FeedbackArchitectureTest 2✅ 432ms

✅ de.tum.cit.aet.artemis.architecture.FeedbackArchitectureTest

✅ testSetLongFeedbackTextNotUsed()
✅ testGetLongFeedbackTextNotUsed()

✅ build/test-results/test/TEST-de.tum.cit.aet.artemis.architecture.RepositoryArchitectureTest.xml

11 tests were completed in 344ms with 11 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.cit.aet.artemis.architecture.RepositoryArchitectureTest 11✅ 344ms

✅ de.tum.cit.aet.artemis.architecture.RepositoryArchitectureTest

✅ testNoEntityGraphsOnQueries()
✅ testNoUnusedRepositoryMethods()
✅ testTransactional()
✅ shouldBeInRepositoryPackage()
✅ testRepositoryParamAnnotation()
✅ orElseThrowShouldNotBeCalled()
✅ repositoriesImplementArtemisJpaRepository()
✅ persistenceShouldNotAccessServices()
✅ testJPQLStyle()
✅ shouldBeNamedRepository()
✅ testOnlySpringTransactionalAnnotation()

✅ build/test-results/test/TEST-de.tum.cit.aet.artemis.architecture.ResourceArchitectureTest.xml

4 tests were completed in 73ms with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.cit.aet.artemis.architecture.ResourceArchitectureTest 4✅ 73ms

✅ de.tum.cit.aet.artemis.architecture.ResourceArchitectureTest

✅ allPublicMethodsShouldReturnResponseEntity()
✅ shouldBeNamedResource()
✅ shouldBeInResourcePackage()
✅ shouldCorrectlyUseRequestMappingAnnotations()

✅ build/test-results/test/TEST-de.tum.cit.aet.artemis.architecture.ServiceArchitectureTest.xml

5 tests were completed in 181ms with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.cit.aet.artemis.architecture.ServiceArchitectureTest 5✅ 181ms

✅ de.tum.cit.aet.artemis.architecture.ServiceArchitectureTest

✅ testCorrectAsyncCalls()
✅ shouldBeNamedService()
✅ testCorrectServiceAnnotation()
✅ shouldBeInServicePackage()
✅ testNoWrongServiceImports()

❌ build/test-results/test/TEST-de.tum.cit.aet.artemis.authorization.AuthorizationArchitectureTest.xml

8 tests were completed in 51ms with 5 passed, 1 failed and 2 skipped.

Test suite Passed Failed Skipped Time
de.tum.cit.aet.artemis.authorization.AuthorizationArchitectureTest 5✅ 1❌ 2⚪ 51ms

❌ de.tum.cit.aet.artemis.authorization.AuthorizationArchitectureTest

⚪ testEnforceAdminAnnotations()
✅ testEnforceAtLeastEditorAnnotations()
✅ testNoPreAuthorizeOnRestEndpoints()
✅ testEnforceAtLeastTutorAnnotations()
✅ testEnforceAtLeastInstructorAnnotations()
❌ testEnforceAtLeastStudentAnnotations()
	java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are annotated with @EnforceAtLeastStudent and are not annotated with @ManualConfig should be declared in classes that reside in a package 'de.tum.cit.aet.artemis.*.web..' and should be declared in classes that reside outside of packages ['de.tum.cit.aet.artemis.*.web.admin..', 'de.tum.cit.aet.artemis.*.web.open..']' was violated (1 times):
⚪ testEnforceNothingAnnotations()
✅ testNoPreAuthorizeOnRestControllers()

✅ build/test-results/test/TEST-de.tum.cit.aet.artemis.domain.notification.NotificationPlaceholderArchitectureTest.xml

2 tests were completed in 37ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.cit.aet.artemis.domain.notification.NotificationPlaceholderArchitectureTest 2✅ 37ms

✅ de.tum.cit.aet.artemis.domain.notification.NotificationPlaceholderArchitectureTest

✅ testNotificationPlaceholderCreatorStringArrayCreation()
✅ testPlaceholderCreatorMethodSignature()

Annotations

Check failure on line 80 in src/test/java/de/tum/cit/aet/artemis/authorization/AuthorizationArchitectureTest.java

See this annotation in the file changed.

@github-actions github-actions / Java Architecture Tests

de.tum.cit.aet.artemis.authorization.AuthorizationArchitectureTest ► testEnforceAtLeastStudentAnnotations()

Failed test found in:
  build/test-results/test/TEST-de.tum.cit.aet.artemis.authorization.AuthorizationArchitectureTest.xml
Error:
  java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are annotated with @EnforceAtLeastStudent and are not annotated with @ManualConfig should be declared in classes that reside in a package 'de.tum.cit.aet.artemis.*.web..' and should be declared in classes that reside outside of packages ['de.tum.cit.aet.artemis.*.web.admin..', 'de.tum.cit.aet.artemis.*.web.open..']' was violated (1 times):
Raw output
java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are annotated with @EnforceAtLeastStudent and are not annotated with @ManualConfig should be declared in classes that reside in a package 'de.tum.cit.aet.artemis.*.web..' and should be declared in classes that reside outside of packages ['de.tum.cit.aet.artemis.*.web.admin..', 'de.tum.cit.aet.artemis.*.web.open..']' was violated (1 times):
Method <de.tum.cit.aet.artemis.core.web.open.PublicUserJwtResource.reKey(boolean, jakarta.servlet.http.HttpServletResponse)> is not declared in classes that reside outside of packages ['de.tum.cit.aet.artemis.*.web.admin..', 'de.tum.cit.aet.artemis.*.web.open..'] in (PublicUserJwtResource.java:112)
	at com.tngtech.archunit.lang.ArchRule$Assertions.assertNoViolation(ArchRule.java:94)
	at com.tngtech.archunit.lang.ArchRule$Assertions.check(ArchRule.java:86)
	at com.tngtech.archunit.lang.ArchRule$Factory$SimpleArchRule.check(ArchRule.java:165)
	at com.tngtech.archunit.lang.syntax.ObjectsShouldInternal.check(ObjectsShouldInternal.java:81)
	at de.tum.cit.aet.artemis.authorization.AuthorizationArchitectureTest.testEnforceAtLeastStudentAnnotations(AuthorizationArchitectureTest.java:80)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)