Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure warnings-related feature flags #30

Open
cfrantz opened this issue Sep 22, 2023 · 0 comments
Open

Reconfigure warnings-related feature flags #30

cfrantz opened this issue Sep 22, 2023 · 0 comments

Comments

@cfrantz
Copy link
Collaborator

cfrantz commented Sep 22, 2023

There are a number of feature flags related to compiler warnings:
https://github.com/lowRISC/crt/blob/main/features/common/BUILD.bazel#L45-L113
https://github.com/lowRISC/crt/blob/main/features/embedded/BUILD.bazel#L91-L104

The feature_single_flag_c_cpp macro defaults each feature to enabled.

While these warnings are relevant to the OpenTitan codebase, they are overly-strict for some codebases. I'd prefer to see some of these features disabled by default and explicitly enabled in a project's .bazelrc file with additional --features=... switches.

We should also consider whether we should group these warnings into classes (ie: low, medium, high) and allow enable/disable of each class of warning feature with a single --features=... switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant