Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitOps with multiple stacks #670

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

Felioh
Copy link

@Felioh Felioh commented Nov 17, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

This is an extension of the PR #471. As that PR has not been merged yet, I do not expect this to be merged, but I still want to give you a chance to see this.

The main addition to the previous PR is that multiple stacks in one Repository can now be used and are correctly shown in Dockge. This is not perfect and there are a lot of improvements to be made. However, this works for me. If anyone finds any bugs I will happily fix them. :)

How does this work?

With this, every folder inside the StacksDir is scanned up to a maximum depth of 3 (This should probably be a setting) for a compose.yml. The Stack names are now not just the parent folder, but everything up until the StacksDir. This means that the name attribute cannot really be used (but before it couldn't either).

Also, I rebased onto the current master.

Type of change

Please delete any options that are not relevant.

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Screenshot 2024-11-17 124412

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant