Rename Shape to Part? #415
Unanswered
louis-langholtz
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I'm considering renaming the
Shape
class toPart
for release 2.0 onward. Besides being a shorter name, it's perhaps more representative of what the class is especially since Pull Request #414. It's become more than just a geometry class. It has other properties as well, like friction, restitution, density, and filtering.One clear downside to me however, is in identifying all the places that
Shape
may have been referenced or also linked and updating those references and links as well. Another, of course, is the additional changes this requires of existing user code wanting to update to 2.0 when it's released.OTOH, a downside to not making this change, would be confusion the
Shape
name (having more than just shape properties) could contribute to new users. And, in regard to requiring changes to user code, the already merged changes that do away withFixture
andFixtureConf
types require changes to similar areas of user code anyway.Regardless of what feedback may be, I may still make or not make this change. I would like to hear from others on this never the less.
Beta Was this translation helpful? Give feedback.
All reactions