Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FxCopRuleAssemblies items shouldn't be included in published .targets file #126

Open
AArnott opened this issue May 5, 2014 · 0 comments · May be fixed by #127
Open

FxCopRuleAssemblies items shouldn't be included in published .targets file #126

AArnott opened this issue May 5, 2014 · 0 comments · May be fixed by #127

Comments

@AArnott
Copy link

AArnott commented May 5, 2014

The MSBuild.Community.Tasks.targets file has this block in it:

<ItemGroup>
  <FxCopRuleAssemblies Include="UsageRules.dll"/>
  <FxCopRuleAssemblies Include="SecurityRules.dll"/>
  <FxCopRuleAssemblies Include="PortabilityRules.dll"/>
  <FxCopRuleAssemblies Include="PerformanceRules.dll"/>
  <FxCopRuleAssemblies Include="MobilityRules.dll"/>
  <FxCopRuleAssemblies Include="InteroperabilityRules.dll"/>
  <FxCopRuleAssemblies Include="GlobalizationRules.dll"/>
  <FxCopRuleAssemblies Include="DesignRules.dll"/>
</ItemGroup>

It looks like this is intended to ensure FxCop runs on this MSBuildTasks project itself. But because it appears in this .targets file that other projects will import, other projects may be forced to run these rules as well. I think these items should be moved to another file that doesn't ship with the .targets file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moves FxCop rules out of publicly shipping .targets file... AArnott/msbuildtasks
1 participant
@AArnott