Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

externally accessible functions #47

Open
MalteLond opened this issue Dec 17, 2018 · 3 comments
Open

externally accessible functions #47

MalteLond opened this issue Dec 17, 2018 · 3 comments

Comments

@MalteLond
Copy link
Collaborator

Which functions should be externally accessible. I propose, similar to glmnet, two functions:

  • hdcd, similar to currently BinarySegmentation
  • cv.hdcd, similar to CrossValidation

I do not like the idea of having one function that does cv if one parameter is missing or similar. Maybe throw a warning, choose lambda according to asymptotic theory, delta = 0.1 and return a list of cps corresponding to different gammas if no params are given. Choose a default method (e.g. glasso) and a default optimizer.

@lorenzha
Copy link
Owner

I agree. Also adapting the structure from glmnet is generally a good idea.

@MalteLond
Copy link
Collaborator Author

Possibly: Change name away from hdcd? E.g. FastChangepointDetection.

@lorenzha
Copy link
Owner

Also generic functions like e.g. plot and print...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants