Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobs: Traders: Не работает скидка для той же расы #1159

Closed
4 tasks done
alek13 opened this issue Sep 16, 2023 · 0 comments
Closed
4 tasks done

Mobs: Traders: Не работает скидка для той же расы #1159

alek13 opened this issue Sep 16, 2023 · 0 comments
Assignees
@alek13
Labels
bug Для задач: ошибка, которую необходимо исправить mobs | entities Связанное с мобами или сущностями
Milestone
2023.09

Comments

@alek13
Copy link
Member

alek13 commented Sep 16, 2023 •
edited
Loading

Причина судя по всему в этом:

to do:

  • ability to configure price as number (in copper_coin): auto-convert into stack_string
  • use only race param, remove race_privilege (in register_trader(), on_rightclick(), ...)
  • move on_move func into inventory_callbacks (use Inventory.get_by_id())
  • add calc discount
@alek13 alek13 added this to Mobs Sep 16, 2023
@alek13 alek13 converted this from a draft issue Sep 16, 2023
@alek13 alek13 added bug Для задач: ошибка, которую необходимо исправить mobs | entities Связанное с мобами или сущностями labels Sep 16, 2023
alek13 added a commit to alek13/lord that referenced this issue Sep 25, 2023
@alek13
Mobs: Traders: Refactoring: change goods table format. Relates to lor…
6b14bc5 
…d-server#1159, lord-server#1149
alek13 added a commit to alek13/lord that referenced this issue Sep 28, 2023
@alek13
Mods: Traders: ability to configure prive as number. Relates to lord-…
f044f05 
…server#1159, lord-server#1149
alek13 added a commit to alek13/lord that referenced this issue Sep 29, 2023
@alek13
Mobs: Traders: no race priv usage; detect same race for player & trad…
5613053 
…er. Relates to lord-server#1159, lord-server#1157
alek13 added a commit to alek13/lord that referenced this issue Sep 29, 2023
@alek13
Mobs: Traders: refactoring: move on_move(). Relates lord-server#1159
25f5382
alek13 added a commit to alek13/lord that referenced this issue Sep 29, 2023
@alek13
Mobs: Traders: add same race discount calc. Resolves lord-server#1159
1551cae
@alek13 alek13 closed this as completed in 0eb97b4 Sep 29, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Mobs Sep 29, 2023
@alek13 alek13 added this to the 2023.09 milestone Sep 29, 2023
@alek13 alek13 self-assigned this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alek13 alek13

Labels
bug Для задач: ошибка, которую необходимо исправить mobs | entities Связанное с мобами или сущностями
Projects
Mobs
Status: Done
Milestone
2023.09
Development

No branches or pull requests
1 participant
@alek13