Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio 2022 throws error message when extensions are imported #62

Open
joe-agent opened this issue Feb 25, 2022 · 3 comments
Open

Comments

@joe-agent
Copy link

image

I have only 4 extensions to be imported. See below:

{
  "id": "04523c0a-cf72-4d8f-983d-fe416c2d3708",
  "name": "My Visual Studio extensions",
  "description": "A collection of my Visual Studio extensions",
  "version": "1.0",
  "extensions": [
    {
      "name": "Markdown Editor",
      "vsixId": "9ca64947-e9ca-4543-bfb8-6cce9be19fd6"
    },
    {
      "name": "Middle Click Scroll",
      "vsixId": "MiddleClickScroll.263a3239-a004-40e6-b790-4fd371832c85"
    },
    {
      "name": "PowerShell Tools for Visual Studio",
      "vsixId": "PowerShellTools.VS2017"
    },
    {
      "name": "Time Stamp Margin",
      "vsixId": "TimeStampMargin.255e8b14-4a53-4eb7-89a7-7ab741c1f612"
    }
  ]
}

Why do I get such issue? How do I fix it? Thanks

Details of my Visual Studio can be found here
vs info.txt

@Herve-M
Copy link

Herve-M commented Jul 28, 2022

Having the exact same problem with diff. extensions.

How to reproduce:

  • Launch VS
  • Extensions > Import & Export > Import & select an manifest files
  • VSIX crash happen

According to Process Explorer, VSIXinstaller.exe is called without an vsix file:
Like "C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\IDE\VSIXInstaller.exe" /instanceIds:9077ad76

Another point, the temporary folder used for downloading file is empty :/

Info.:

  • Microsoft Visual Studio Professional 2022 (64-bit)
  • 17.2.5

@Herve-M
Copy link

Herve-M commented Jul 31, 2022

I don't know yet why but the problem is located at https://github.com/madskristensen/ExtensionPackTools/blob/fcdb9ef980612d9e41071b6a59ebb50ac25debfb/src/ExtensionManager.Shared/Commands/ImportCommand.cs#L76, it don't always return expected result or the behind logic don't work for all "vsixId".

@Herve-M
Copy link

Herve-M commented Aug 1, 2022

After more research it looks like that repository.GetVSGalleryExtensions filter out extension who aren't compatible with the current version of VS.
Example:

  • GitHub Extension for Visual Studio -> not returned as no vsix build for VS-2022
  • KnownMonikers Explorer -> not returned as no vsix build for VS-2022, at least under id c38f3512-4653-4d97-a4c5-860a425209f5

When looking at your shared manifest @joe-agent none of them (extension) are build for VS-2022 according to the marketplace. (seen under Works with)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants