Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(talos): v2 engine support #981

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#7791

What this PR does / why we need it:

Add important notes and instructions outlining the v2 engine support for Talos Linux.

Special notes for your reviewer:

None

Additional documentation or context

None

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 6a4f7f3
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/66d66a5ca19730000886054b
😎 Deploy Preview https://deploy-preview-981--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit b182ba4
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/66d6b185df293c0008c94160
😎 Deploy Preview https://deploy-preview-981--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@c3y1huang c3y1huang marked this pull request as ready for review September 3, 2024 01:49
@c3y1huang c3y1huang requested a review from a team as a code owner September 3, 2024 01:49
derekbit
derekbit previously approved these changes Sep 3, 2024
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit
Copy link
Member

derekbit commented Sep 3, 2024

Waiting for @jillian-maroket and @jhkrug's review.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have concerns about the changes.

longhorn/longhorn-7791

Signed-off-by: Chin-Ya Huang <[email protected]>
@c3y1huang
Copy link
Contributor Author

Let me know if you have concerns about the changes.

The suggestions LGTM, I've made the changes. PTAL, thank you!

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@innobead innobead merged commit 251f47d into longhorn:master Sep 3, 2024
6 checks passed
@c3y1huang c3y1huang deleted the feat-v2-talos-support branch September 3, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants