Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(1.7.0): update danger zone settings block #923

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

a110605
Copy link
Contributor

@a110605 a110605 commented Jun 11, 2024

Which issue(s) this PR fixes:

Issue # [UI][IMPROVEMENT] Improve the UX of updating danger zone settings

What this PR does / why we need it:

Due to UI PR change, the unapplied danger zone settings will show up on the top of danger zone block.
See recording in longhorn/longhorn-ui#735

Special notes for your reviewer:

N/A

Additional documentation or context

N/A

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 3dac552
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/6669681b9e708100083dc235
😎 Deploy Preview https://deploy-preview-923--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@a110605 a110605 force-pushed the update_unapplied_Settings_doc branch from 0600b86 to 30133fa Compare June 11, 2024 04:48
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworded the new sentence and also split the paragraph to make reading easier.

content/docs/1.7.0/deploy/important-notes/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit fb32bc6 into longhorn:master Jun 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants