Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement playEnumeratorToChunkerator without promises #2

Open
sullivan- opened this issue Mar 17, 2017 · 2 comments
Open

Implement playEnumeratorToChunkerator without promises #2

sullivan- opened this issue Mar 17, 2017 · 2 comments

Comments

@sullivan-
Copy link
Member

The current implementation of this method is a little lame, using promises to communicate between the producer and the consumer. There's got to be a better approach. I'd like this method to work without any dependencies besides Play and Scala standard library, so that's a limiting factor.

@sullivan-
Copy link
Member Author

On a related note, the producer Iteratee could benefit from chunking approach. I won't raise this into a separate issue, because if we do get rid of the promises, then the current non-chunking code will have changed dramatically.

But it's worth noting that a non-promise based implementation would be better if it also did chunking.

@sullivan-
Copy link
Member Author

I'd like to mention that I myself am only using this adapter in a test suite, so getting a better implementation here may well be a lot more important to you than it is to me. Of course, I want to see this project beautiful and complete. But I have a lot of priorities to balance. If you care, please consider chipping in! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant