Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Upgrade plugin API and embedding to work with Flutter v2 #49

Merged
merged 21 commits into from
Oct 5, 2021
Merged

Upgrade plugin API and embedding to work with Flutter v2 #49

merged 21 commits into from
Oct 5, 2021

Conversation

enveraltin
Copy link

No description provided.

maxzod and others added 19 commits April 2, 2021 02:14
@maxzod
update dependencies
b6612fe
@lohanidamodar
Merge pull request lohanidamodar#43 from lohanidamodar/develop
2793178 
2.0.0 release
@maxzod
Merge pull request maxzod#1 from lohanidamodar/develop
c68b7eb 
Develop
@maxzod
apply strict linter - conflict
51ed114
@maxzod
Merge branch 'master' into develop
c995702
@maxzod
Merge pull request maxzod#2 from maxzod/develop
5fa45ba 
Develop
@enveraltin
Merge remote-tracking branch 'lohanidamodar/master'
597ad26
@enveraltin
Workaround for NPE, ignore IDE project files.
7d1d877
@enveraltin
Bump version, upgrade dependencies.
1d7279a
@enveraltin
Ignored files cleanup.
666cd2b
@enveraltin
More deleted files.
abea050
@enveraltin
Delete flutter_plugin_pdf_viewer.iml
fbc55b2
@enveraltin
More Eclipse artifacts cleanup.
7c5393a
@enveraltin
Update Gradle dependencies.
a6ad35d
@enveraltin
Upgrade old Flutter embedding.
4b7a4d3
@enveraltin
Upgrade Flutter embedding.
dc25cf9
@enveraltin
Better error logging, maybe properly time cache deletion.
d3e8e64
@enveraltin
Make sure file is closed when done.
9a21498
@enveraltin
Make sure file is closed when done, better this time.
b26a6d7
@enveraltin
Copy link
Author

This branch contains @maxzod 's changes as well.

@enveraltin enveraltin mentioned this pull request Jun 1, 2021
Open
@dryasbk dryasbk mentioned this pull request Aug 11, 2021
Open
@SebastienBtr SebastienBtr mentioned this pull request Sep 21, 2021
Open
@paulocoutinhox
Copy link

MERGE!!!

@enveraltin
Copy link
Author

For anyone waiting for a merge here, feel free to use my forked repo in your pubspec.yaml like this:

    advance_pdf_viewer:
        git:
            url: https://github.com/enveraltin/pdf_viewer.git

Cheers.

@Giber05
Copy link

Giber05 commented Oct 5, 2021

@enveraltin i'm getting force close when i load file from url.

lohanidamodar
lohanidamodar reviewed Oct 5, 2021
View reviewed changes
pubspec.yaml Outdated Show resolved Hide resolved
lohanidamodar
lohanidamodar reviewed Oct 5, 2021
View reviewed changes
pubspec.yaml Outdated Show resolved Hide resolved
@lohanidamodar lohanidamodar changed the base branch from master to develop October 5, 2021 12:14
@lohanidamodar lohanidamodar merged commit 5159064 into lohanidamodar:develop Oct 5, 2021
@enveraltin
Copy link
Author

enveraltin commented Oct 18, 2021 •
edited
Loading

@enveraltin i'm getting force close when i load file from url.

Are you testing on a device without GMS, by any chance? A Huawei device, perhaps?

@gtu-myowin
Copy link

gtu-myowin commented Oct 30, 2021 •
edited
Loading

@enveraltin i'm getting force close when i load file from url.

Are you testing on a device without GMS, by any chance? A Huawei device, perhaps?

@enveraltin

I just got the same error. The stack trace is mentioned in this issue #86

My device was Pixel XL API 30 (android-x86 emulator). It was fine on iOS Simulator.

@elmariocarlos
Copy link

Hi @lohanidamodar here is the PR request that us not moving forwrd to fix some of the issues;I'll also tag you in another two open issues.

@choowx2002 choowx2002 mentioned this pull request Aug 16, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lohanidamodar lohanidamodar lohanidamodar left review comments

@cedteg cedteg cedteg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@enveraltin @paulocoutinhox @Giber05 @gtu-myowin @elmariocarlos @lohanidamodar @cedteg @maxzod